9f82c3262b
* Extend RabbitMQ instance parameters (#409) * Extend Schema * initial parameter integration in resource * datasource, resource and acceptance testing * add docs, fix map fields edge case * improve testing * rename tls_protocols to singular * revert renaming * Extend Redis instance parameters (#410) * Extend Schema * initial parameter integration in resource * datasource, resource and acceptance testing * add docs, fix map fields edge case * improve testing * rename tls_protocols to singular * revert renaming * initial schema * resource and datasource * acceptance testing * fix linting and testing, generate docs * improve acceptance testing --------- Co-authored-by: Diogo Ferrão <diogo.ferrao@freiheit.com>
327 lines
14 KiB
Go
327 lines
14 KiB
Go
package redis_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
|
|
"github.com/hashicorp/terraform-plugin-testing/terraform"
|
|
"github.com/stackitcloud/stackit-sdk-go/core/config"
|
|
"github.com/stackitcloud/stackit-sdk-go/core/utils"
|
|
"github.com/stackitcloud/stackit-sdk-go/services/redis"
|
|
"github.com/stackitcloud/stackit-sdk-go/services/redis/wait"
|
|
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
|
|
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil"
|
|
)
|
|
|
|
// Instance resource data
|
|
var instanceResource = map[string]string{
|
|
"project_id": testutil.ProjectId,
|
|
"name": testutil.ResourceNameWithDateTime("redis"),
|
|
"plan_id": "96e24604-7a43-4ff8-9ba4-609d4235a137",
|
|
"plan_name": "stackit-redis-1.4.10-single",
|
|
"version": "6",
|
|
"sgw_acl_invalid": "1.2.3.4/4",
|
|
"sgw_acl_valid": "192.168.0.0/16",
|
|
"sgw_acl_valid2": "10.10.10.0/24",
|
|
}
|
|
|
|
func parametersConfig(params map[string]string) string {
|
|
nonStringParams := []string{
|
|
"down_after_milliseconds",
|
|
"enable_monitoring",
|
|
"failover_timeout",
|
|
"lua_time_limit",
|
|
"max_disk_threshold",
|
|
"maxclients",
|
|
"maxmemory_samples",
|
|
"metrics_frequency",
|
|
"min_replicas_max_lag",
|
|
"syslog",
|
|
"tls_ciphers",
|
|
}
|
|
parameters := "parameters = {"
|
|
for k, v := range params {
|
|
if utils.Contains(nonStringParams, k) {
|
|
parameters += fmt.Sprintf("%s = %s\n", k, v)
|
|
} else {
|
|
parameters += fmt.Sprintf("%s = %q\n", k, v)
|
|
}
|
|
}
|
|
parameters += "\n}"
|
|
return parameters
|
|
}
|
|
|
|
func resourceConfig(params map[string]string) string {
|
|
return fmt.Sprintf(`
|
|
%s
|
|
|
|
resource "stackit_redis_instance" "instance" {
|
|
project_id = "%s"
|
|
name = "%s"
|
|
plan_name = "%s"
|
|
version = "%s"
|
|
%s
|
|
}
|
|
|
|
%s
|
|
`,
|
|
testutil.RedisProviderConfig(),
|
|
instanceResource["project_id"],
|
|
instanceResource["name"],
|
|
instanceResource["plan_name"],
|
|
instanceResource["version"],
|
|
parametersConfig(params),
|
|
resourceConfigCredential(),
|
|
)
|
|
}
|
|
|
|
func resourceConfigCredential() string {
|
|
return `
|
|
resource "stackit_redis_credential" "credential" {
|
|
project_id = stackit_redis_instance.instance.project_id
|
|
instance_id = stackit_redis_instance.instance.instance_id
|
|
}
|
|
`
|
|
}
|
|
|
|
func TestAccRedisResource(t *testing.T) {
|
|
resource.Test(t, resource.TestCase{
|
|
ProtoV6ProviderFactories: testutil.TestAccProtoV6ProviderFactories,
|
|
CheckDestroy: testAccCheckRedisDestroy,
|
|
Steps: []resource.TestStep{
|
|
// Creation fail
|
|
{
|
|
Config: resourceConfig(map[string]string{"sgw_acl": instanceResource["sgw_acl_invalid"]}),
|
|
ExpectError: regexp.MustCompile(`.*sgw_acl is invalid.*`),
|
|
},
|
|
// Creation
|
|
{
|
|
Config: resourceConfig(map[string]string{
|
|
"sgw_acl": instanceResource["sgw_acl_valid"],
|
|
"down_after_milliseconds": "10000",
|
|
"enable_monitoring": "false",
|
|
"failover_timeout": "30000",
|
|
"graphite": "graphite.example.com:2003",
|
|
"lazyfree_lazy_eviction": "no",
|
|
"lazyfree_lazy_expire": "no",
|
|
"lua_time_limit": "5000",
|
|
"max_disk_threshold": "80",
|
|
"maxclients": "10000",
|
|
"maxmemory_policy": "volatile-lru",
|
|
"maxmemory_samples": "5",
|
|
"metrics_frequency": "10",
|
|
"metrics_prefix": "prefix",
|
|
"min_replicas_max_lag": "15",
|
|
"monitoring_instance_id": "mid",
|
|
"notify_keyspace_events": "Ex",
|
|
"syslog": `["syslog.example.com:123"]`,
|
|
"tls_protocols": "TLSv1.2",
|
|
}),
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
// Instance data
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "project_id", instanceResource["project_id"]),
|
|
resource.TestCheckResourceAttrSet("stackit_redis_instance.instance", "instance_id"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "plan_id", instanceResource["plan_id"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "plan_name", instanceResource["plan_name"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "version", instanceResource["version"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "name", instanceResource["name"]),
|
|
|
|
// Instance Params data
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.sgw_acl", instanceResource["sgw_acl_valid"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.down_after_milliseconds", "10000"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.enable_monitoring", "false"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.failover_timeout", "30000"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.graphite", "graphite.example.com:2003"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.lazyfree_lazy_eviction", "no"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.lazyfree_lazy_expire", "no"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.lua_time_limit", "5000"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.max_disk_threshold", "80"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.maxclients", "10000"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.maxmemory_policy", "volatile-lru"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.maxmemory_samples", "5"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.metrics_frequency", "10"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.metrics_prefix", "prefix"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.min_replicas_max_lag", "15"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.monitoring_instance_id", "mid"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.notify_keyspace_events", "Ex"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.syslog.#", "1"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.syslog.0", "syslog.example.com:123"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.tls_protocols", "TLSv1.2"),
|
|
|
|
// Credential data
|
|
resource.TestCheckResourceAttrPair(
|
|
"stackit_redis_credential.credential", "project_id",
|
|
"stackit_redis_instance.instance", "project_id",
|
|
),
|
|
resource.TestCheckResourceAttrPair(
|
|
"stackit_redis_credential.credential", "instance_id",
|
|
"stackit_redis_instance.instance", "instance_id",
|
|
),
|
|
resource.TestCheckResourceAttrSet("stackit_redis_credential.credential", "credential_id"),
|
|
resource.TestCheckResourceAttrSet("stackit_redis_credential.credential", "host"),
|
|
),
|
|
},
|
|
// data source
|
|
{
|
|
Config: fmt.Sprintf(`
|
|
%s
|
|
|
|
data "stackit_redis_instance" "instance" {
|
|
project_id = stackit_redis_instance.instance.project_id
|
|
instance_id = stackit_redis_instance.instance.instance_id
|
|
}
|
|
|
|
data "stackit_redis_credential" "credential" {
|
|
project_id = stackit_redis_credential.credential.project_id
|
|
instance_id = stackit_redis_credential.credential.instance_id
|
|
credential_id = stackit_redis_credential.credential.credential_id
|
|
}`,
|
|
resourceConfig(nil),
|
|
),
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
// Instance data
|
|
resource.TestCheckResourceAttr("data.stackit_redis_instance.instance", "project_id", instanceResource["project_id"]),
|
|
resource.TestCheckResourceAttrPair("stackit_redis_instance.instance", "instance_id",
|
|
"data.stackit_redis_credential.credential", "instance_id"),
|
|
resource.TestCheckResourceAttrPair("data.stackit_redis_instance.instance", "instance_id",
|
|
"data.stackit_redis_credential.credential", "instance_id"),
|
|
resource.TestCheckResourceAttr("data.stackit_redis_instance.instance", "plan_id", instanceResource["plan_id"]),
|
|
resource.TestCheckResourceAttr("data.stackit_redis_instance.instance", "name", instanceResource["name"]),
|
|
resource.TestCheckResourceAttrSet("data.stackit_redis_instance.instance", "parameters.sgw_acl"),
|
|
|
|
// Credentials data
|
|
resource.TestCheckResourceAttr("data.stackit_redis_credential.credential", "project_id", instanceResource["project_id"]),
|
|
resource.TestCheckResourceAttrSet("data.stackit_redis_credential.credential", "credential_id"),
|
|
resource.TestCheckResourceAttrSet("data.stackit_redis_credential.credential", "host"),
|
|
resource.TestCheckResourceAttrSet("data.stackit_redis_credential.credential", "port"),
|
|
resource.TestCheckResourceAttrSet("data.stackit_redis_credential.credential", "uri"),
|
|
resource.TestCheckResourceAttrSet("data.stackit_redis_credential.credential", "load_balanced_host"),
|
|
),
|
|
},
|
|
// Import
|
|
{
|
|
ResourceName: "stackit_redis_instance.instance",
|
|
ImportStateIdFunc: func(s *terraform.State) (string, error) {
|
|
r, ok := s.RootModule().Resources["stackit_redis_instance.instance"]
|
|
if !ok {
|
|
return "", fmt.Errorf("couldn't find resource stackit_redis_instance.instance")
|
|
}
|
|
instanceId, ok := r.Primary.Attributes["instance_id"]
|
|
if !ok {
|
|
return "", fmt.Errorf("couldn't find attribute instance_id")
|
|
}
|
|
return fmt.Sprintf("%s,%s", testutil.ProjectId, instanceId), nil
|
|
},
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
{
|
|
ResourceName: "stackit_redis_credential.credential",
|
|
ImportStateIdFunc: func(s *terraform.State) (string, error) {
|
|
r, ok := s.RootModule().Resources["stackit_redis_credential.credential"]
|
|
if !ok {
|
|
return "", fmt.Errorf("couldn't find resource stackit_redis_credential.credential")
|
|
}
|
|
instanceId, ok := r.Primary.Attributes["instance_id"]
|
|
if !ok {
|
|
return "", fmt.Errorf("couldn't find attribute instance_id")
|
|
}
|
|
credentialId, ok := r.Primary.Attributes["credential_id"]
|
|
if !ok {
|
|
return "", fmt.Errorf("couldn't find attribute credential_id")
|
|
}
|
|
return fmt.Sprintf("%s,%s,%s", testutil.ProjectId, instanceId, credentialId), nil
|
|
},
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
// Update
|
|
{
|
|
Config: resourceConfig(map[string]string{"sgw_acl": instanceResource["sgw_acl_valid2"]}),
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
// Instance data
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "project_id", instanceResource["project_id"]),
|
|
resource.TestCheckResourceAttrSet("stackit_redis_instance.instance", "instance_id"),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "plan_id", instanceResource["plan_id"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "plan_name", instanceResource["plan_name"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "version", instanceResource["version"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "name", instanceResource["name"]),
|
|
resource.TestCheckResourceAttr("stackit_redis_instance.instance", "parameters.sgw_acl", instanceResource["sgw_acl_valid2"]),
|
|
),
|
|
},
|
|
// Deletion is done by the framework implicitly
|
|
},
|
|
})
|
|
}
|
|
|
|
func checkInstanceDeleteSuccess(i *redis.Instance) bool {
|
|
if *i.LastOperation.Type != wait.InstanceTypeDelete {
|
|
return false
|
|
}
|
|
|
|
if *i.LastOperation.Type == wait.InstanceTypeDelete {
|
|
if *i.LastOperation.State != wait.InstanceStateSuccess {
|
|
return false
|
|
} else if strings.Contains(*i.LastOperation.Description, "DeleteFailed") || strings.Contains(*i.LastOperation.Description, "failed") {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
func testAccCheckRedisDestroy(s *terraform.State) error {
|
|
ctx := context.Background()
|
|
var client *redis.APIClient
|
|
var err error
|
|
if testutil.RedisCustomEndpoint == "" {
|
|
client, err = redis.NewAPIClient(
|
|
config.WithRegion("eu01"),
|
|
)
|
|
} else {
|
|
client, err = redis.NewAPIClient(
|
|
config.WithEndpoint(testutil.RedisCustomEndpoint),
|
|
)
|
|
}
|
|
if err != nil {
|
|
return fmt.Errorf("creating client: %w", err)
|
|
}
|
|
|
|
instancesToDestroy := []string{}
|
|
for _, rs := range s.RootModule().Resources {
|
|
if rs.Type != "stackit_redis_instance" {
|
|
continue
|
|
}
|
|
// instance terraform ID: "[project_id],[instance_id]"
|
|
instanceId := strings.Split(rs.Primary.ID, core.Separator)[1]
|
|
instancesToDestroy = append(instancesToDestroy, instanceId)
|
|
}
|
|
|
|
instancesResp, err := client.ListInstances(ctx, testutil.ProjectId).Execute()
|
|
if err != nil {
|
|
return fmt.Errorf("getting instancesResp: %w", err)
|
|
}
|
|
|
|
instances := *instancesResp.Instances
|
|
for i := range instances {
|
|
if instances[i].InstanceId == nil {
|
|
continue
|
|
}
|
|
if utils.Contains(instancesToDestroy, *instances[i].InstanceId) {
|
|
if !checkInstanceDeleteSuccess(&instances[i]) {
|
|
err := client.DeleteInstanceExecute(ctx, testutil.ProjectId, *instances[i].InstanceId)
|
|
if err != nil {
|
|
return fmt.Errorf("destroying instance %s during CheckDestroy: %w", *instances[i].InstanceId, err)
|
|
}
|
|
_, err = wait.DeleteInstanceWaitHandler(ctx, client, testutil.ProjectId, *instances[i].InstanceId).WaitWithContext(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("destroying instance %s during CheckDestroy: waiting for deletion %w", *instances[i].InstanceId, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|