78793f49ff
* Extend OpenSearch instance parameters * Fix bug in parameter modelling * Improve monitoring_instance_id field documentation * Fix unit test
370 lines
10 KiB
Go
370 lines
10 KiB
Go
package opensearch
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/hashicorp/terraform-plugin-framework/attr"
|
|
"github.com/hashicorp/terraform-plugin-framework/types"
|
|
"github.com/hashicorp/terraform-plugin-framework/types/basetypes"
|
|
"github.com/stackitcloud/stackit-sdk-go/core/utils"
|
|
"github.com/stackitcloud/stackit-sdk-go/services/opensearch"
|
|
)
|
|
|
|
var fixtureModelParameters = types.ObjectValueMust(parametersTypes, map[string]attr.Value{
|
|
"sgw_acl": types.StringValue("acl"),
|
|
"enable_monitoring": types.BoolValue(true),
|
|
"graphite": types.StringValue("graphite"),
|
|
"java_garbage_collector": types.StringValue("gc"),
|
|
"java_heapspace": types.Int64Value(10),
|
|
"java_maxmetaspace": types.Int64Value(10),
|
|
"max_disk_threshold": types.Int64Value(10),
|
|
"metrics_frequency": types.Int64Value(10),
|
|
"metrics_prefix": types.StringValue("prefix"),
|
|
"monitoring_instance_id": types.StringValue("mid"),
|
|
"plugins": types.ListValueMust(types.StringType, []attr.Value{
|
|
types.StringValue("plugin"),
|
|
types.StringValue("plugin2"),
|
|
}),
|
|
"syslog": types.ListValueMust(types.StringType, []attr.Value{
|
|
types.StringValue("syslog"),
|
|
types.StringValue("syslog2"),
|
|
}),
|
|
"tls_ciphers": types.ListValueMust(types.StringType, []attr.Value{
|
|
types.StringValue("cipher"),
|
|
types.StringValue("cipher2"),
|
|
}),
|
|
"tls_protocols": types.StringValue("protocol"),
|
|
})
|
|
|
|
var fixtureNullModelParameters = types.ObjectValueMust(parametersTypes, map[string]attr.Value{
|
|
"sgw_acl": types.StringNull(),
|
|
"enable_monitoring": types.BoolNull(),
|
|
"graphite": types.StringNull(),
|
|
"java_garbage_collector": types.StringNull(),
|
|
"java_heapspace": types.Int64Null(),
|
|
"java_maxmetaspace": types.Int64Null(),
|
|
"max_disk_threshold": types.Int64Null(),
|
|
"metrics_frequency": types.Int64Null(),
|
|
"metrics_prefix": types.StringNull(),
|
|
"monitoring_instance_id": types.StringNull(),
|
|
"plugins": types.ListNull(types.StringType),
|
|
"syslog": types.ListNull(types.StringType),
|
|
"tls_ciphers": types.ListNull(types.StringType),
|
|
"tls_protocols": types.StringNull(),
|
|
})
|
|
|
|
var fixtureInstanceParameters = opensearch.InstanceParameters{
|
|
SgwAcl: utils.Ptr("acl"),
|
|
EnableMonitoring: utils.Ptr(true),
|
|
Graphite: utils.Ptr("graphite"),
|
|
JavaGarbageCollector: utils.Ptr("gc"),
|
|
JavaHeapspace: utils.Ptr(int64(10)),
|
|
JavaMaxmetaspace: utils.Ptr(int64(10)),
|
|
MaxDiskThreshold: utils.Ptr(int64(10)),
|
|
MetricsFrequency: utils.Ptr(int64(10)),
|
|
MetricsPrefix: utils.Ptr("prefix"),
|
|
MonitoringInstanceId: utils.Ptr("mid"),
|
|
Plugins: &[]string{"plugin", "plugin2"},
|
|
Syslog: &[]string{"syslog", "syslog2"},
|
|
TlsCiphers: &[]string{"cipher", "cipher2"},
|
|
TlsProtocols: utils.Ptr("protocol"),
|
|
}
|
|
|
|
func TestMapFields(t *testing.T) {
|
|
tests := []struct {
|
|
description string
|
|
input *opensearch.Instance
|
|
expected Model
|
|
isValid bool
|
|
}{
|
|
{
|
|
"default_values",
|
|
&opensearch.Instance{},
|
|
Model{
|
|
Id: types.StringValue("pid,iid"),
|
|
InstanceId: types.StringValue("iid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
PlanId: types.StringNull(),
|
|
Name: types.StringNull(),
|
|
CfGuid: types.StringNull(),
|
|
CfSpaceGuid: types.StringNull(),
|
|
DashboardUrl: types.StringNull(),
|
|
ImageUrl: types.StringNull(),
|
|
CfOrganizationGuid: types.StringNull(),
|
|
Parameters: types.ObjectNull(parametersTypes),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"simple_values",
|
|
&opensearch.Instance{
|
|
PlanId: utils.Ptr("plan"),
|
|
CfGuid: utils.Ptr("cf"),
|
|
CfSpaceGuid: utils.Ptr("space"),
|
|
DashboardUrl: utils.Ptr("dashboard"),
|
|
ImageUrl: utils.Ptr("image"),
|
|
InstanceId: utils.Ptr("iid"),
|
|
Name: utils.Ptr("name"),
|
|
CfOrganizationGuid: utils.Ptr("org"),
|
|
Parameters: &map[string]interface{}{
|
|
// Using "-" on purpose on some fields because that is the API response
|
|
"sgw_acl": "acl",
|
|
"enable_monitoring": true,
|
|
"graphite": "graphite",
|
|
"java_garbage_collector": "gc",
|
|
"java_heapspace": int64(10),
|
|
"java_maxmetaspace": int64(10),
|
|
"max_disk_threshold": int64(10),
|
|
"metrics_frequency": int64(10),
|
|
"metrics_prefix": "prefix",
|
|
"monitoring_instance_id": "mid",
|
|
"plugins": []string{"plugin", "plugin2"},
|
|
"syslog": []string{"syslog", "syslog2"},
|
|
"tls-ciphers": []string{"cipher", "cipher2"},
|
|
"tls-protocols": "protocol",
|
|
},
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,iid"),
|
|
InstanceId: types.StringValue("iid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
PlanId: types.StringValue("plan"),
|
|
Name: types.StringValue("name"),
|
|
CfGuid: types.StringValue("cf"),
|
|
CfSpaceGuid: types.StringValue("space"),
|
|
DashboardUrl: types.StringValue("dashboard"),
|
|
ImageUrl: types.StringValue("image"),
|
|
CfOrganizationGuid: types.StringValue("org"),
|
|
Parameters: fixtureModelParameters,
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"nil_response",
|
|
nil,
|
|
Model{},
|
|
false,
|
|
},
|
|
{
|
|
"no_resource_id",
|
|
&opensearch.Instance{},
|
|
Model{},
|
|
false,
|
|
},
|
|
{
|
|
"wrong_param_types_1",
|
|
&opensearch.Instance{
|
|
Parameters: &map[string]interface{}{
|
|
"sgw_acl": true,
|
|
},
|
|
},
|
|
Model{},
|
|
false,
|
|
},
|
|
{
|
|
"wrong_param_types_2",
|
|
&opensearch.Instance{
|
|
Parameters: &map[string]interface{}{
|
|
"sgw_acl": 1,
|
|
},
|
|
},
|
|
Model{},
|
|
false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
state := &Model{
|
|
ProjectId: tt.expected.ProjectId,
|
|
InstanceId: tt.expected.InstanceId,
|
|
}
|
|
err := mapFields(tt.input, state)
|
|
if !tt.isValid && err == nil {
|
|
t.Fatalf("Should have failed")
|
|
}
|
|
if tt.isValid && err != nil {
|
|
t.Fatalf("Should not have failed: %v", err)
|
|
}
|
|
if tt.isValid {
|
|
diff := cmp.Diff(state, &tt.expected)
|
|
if diff != "" {
|
|
t.Fatalf("Data does not match: %s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestToCreatePayload(t *testing.T) {
|
|
tests := []struct {
|
|
description string
|
|
input *Model
|
|
expected *opensearch.CreateInstancePayload
|
|
isValid bool
|
|
}{
|
|
{
|
|
"default_values",
|
|
&Model{},
|
|
&opensearch.CreateInstancePayload{},
|
|
true,
|
|
},
|
|
{
|
|
"simple_values",
|
|
&Model{
|
|
Name: types.StringValue("name"),
|
|
PlanId: types.StringValue("plan"),
|
|
Parameters: fixtureModelParameters,
|
|
},
|
|
&opensearch.CreateInstancePayload{
|
|
InstanceName: utils.Ptr("name"),
|
|
Parameters: &fixtureInstanceParameters,
|
|
PlanId: utils.Ptr("plan"),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"null_fields_and_int_conversions",
|
|
&Model{
|
|
Name: types.StringValue(""),
|
|
PlanId: types.StringValue(""),
|
|
Parameters: fixtureNullModelParameters,
|
|
},
|
|
&opensearch.CreateInstancePayload{
|
|
InstanceName: utils.Ptr(""),
|
|
Parameters: &opensearch.InstanceParameters{},
|
|
PlanId: utils.Ptr(""),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"nil_model",
|
|
nil,
|
|
nil,
|
|
false,
|
|
},
|
|
{
|
|
"nil_parameters",
|
|
&Model{
|
|
Name: types.StringValue("name"),
|
|
PlanId: types.StringValue("plan"),
|
|
},
|
|
&opensearch.CreateInstancePayload{
|
|
InstanceName: utils.Ptr("name"),
|
|
PlanId: utils.Ptr("plan"),
|
|
},
|
|
true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
var parameters *parametersModel
|
|
if tt.input != nil {
|
|
if !(tt.input.Parameters.IsNull() || tt.input.Parameters.IsUnknown()) {
|
|
parameters = ¶metersModel{}
|
|
diags := tt.input.Parameters.As(context.Background(), parameters, basetypes.ObjectAsOptions{})
|
|
if diags.HasError() {
|
|
t.Fatalf("Error converting parameters: %v", diags.Errors())
|
|
}
|
|
}
|
|
}
|
|
output, err := toCreatePayload(tt.input, parameters)
|
|
if !tt.isValid && err == nil {
|
|
t.Fatalf("Should have failed")
|
|
}
|
|
if tt.isValid && err != nil {
|
|
t.Fatalf("Should not have failed: %v", err)
|
|
}
|
|
if tt.isValid {
|
|
diff := cmp.Diff(output, tt.expected)
|
|
if diff != "" {
|
|
t.Fatalf("Data does not match: %s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestToUpdatePayload(t *testing.T) {
|
|
tests := []struct {
|
|
description string
|
|
input *Model
|
|
expected *opensearch.PartialUpdateInstancePayload
|
|
isValid bool
|
|
}{
|
|
{
|
|
"default_values",
|
|
&Model{},
|
|
&opensearch.PartialUpdateInstancePayload{},
|
|
true,
|
|
},
|
|
{
|
|
"simple_values",
|
|
&Model{
|
|
PlanId: types.StringValue("plan"),
|
|
Parameters: fixtureModelParameters,
|
|
},
|
|
&opensearch.PartialUpdateInstancePayload{
|
|
Parameters: &fixtureInstanceParameters,
|
|
PlanId: utils.Ptr("plan"),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"null_fields_and_int_conversions",
|
|
&Model{
|
|
PlanId: types.StringValue(""),
|
|
Parameters: fixtureNullModelParameters,
|
|
},
|
|
&opensearch.PartialUpdateInstancePayload{
|
|
Parameters: &opensearch.InstanceParameters{},
|
|
PlanId: utils.Ptr(""),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"nil_model",
|
|
nil,
|
|
nil,
|
|
false,
|
|
},
|
|
{
|
|
"nil_parameters",
|
|
&Model{
|
|
PlanId: types.StringValue("plan"),
|
|
},
|
|
&opensearch.PartialUpdateInstancePayload{
|
|
PlanId: utils.Ptr("plan"),
|
|
},
|
|
true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
var parameters *parametersModel
|
|
if tt.input != nil {
|
|
if !(tt.input.Parameters.IsNull() || tt.input.Parameters.IsUnknown()) {
|
|
parameters = ¶metersModel{}
|
|
diags := tt.input.Parameters.As(context.Background(), parameters, basetypes.ObjectAsOptions{})
|
|
if diags.HasError() {
|
|
t.Fatalf("Error converting parameters: %v", diags.Errors())
|
|
}
|
|
}
|
|
}
|
|
output, err := toUpdatePayload(tt.input, parameters)
|
|
if !tt.isValid && err == nil {
|
|
t.Fatalf("Should have failed")
|
|
}
|
|
if tt.isValid && err != nil {
|
|
t.Fatalf("Should not have failed: %v", err)
|
|
}
|
|
if tt.isValid {
|
|
diff := cmp.Diff(output, tt.expected)
|
|
if diff != "" {
|
|
t.Fatalf("Data does not match: %s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|