2923621ab0
* feat: completed bucket and credential group * feat: fix linter warnings * feat: updated documentation * feat: updated to current version of the regional api * feat: implement review findings * feat: implement further review findings * fix: make sure region is stored for the data-source in the state
446 lines
12 KiB
Go
446 lines
12 KiB
Go
package objectstorage
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/hashicorp/terraform-plugin-framework/types"
|
|
"github.com/stackitcloud/stackit-sdk-go/core/config"
|
|
"github.com/stackitcloud/stackit-sdk-go/core/utils"
|
|
"github.com/stackitcloud/stackit-sdk-go/services/objectstorage"
|
|
)
|
|
|
|
type objectStorageClientMocked struct {
|
|
returnError bool
|
|
}
|
|
|
|
func (c *objectStorageClientMocked) EnableServiceExecute(_ context.Context, projectId, _ string) (*objectstorage.ProjectStatus, error) {
|
|
if c.returnError {
|
|
return nil, fmt.Errorf("create project failed")
|
|
}
|
|
|
|
return &objectstorage.ProjectStatus{
|
|
Project: utils.Ptr(projectId),
|
|
}, nil
|
|
}
|
|
|
|
func TestMapFields(t *testing.T) {
|
|
now := time.Now()
|
|
|
|
tests := []struct {
|
|
description string
|
|
input *objectstorage.CreateAccessKeyResponse
|
|
expected Model
|
|
isValid bool
|
|
}{
|
|
{
|
|
"default_values",
|
|
&objectstorage.CreateAccessKeyResponse{},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringNull(),
|
|
AccessKey: types.StringNull(),
|
|
SecretAccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringNull(),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"simple_values",
|
|
&objectstorage.CreateAccessKeyResponse{
|
|
AccessKey: utils.Ptr("key"),
|
|
DisplayName: utils.Ptr("name"),
|
|
Expires: utils.Ptr(now.Format(time.RFC3339)),
|
|
SecretAccessKey: utils.Ptr("secret-key"),
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringValue("name"),
|
|
AccessKey: types.StringValue("key"),
|
|
SecretAccessKey: types.StringValue("secret-key"),
|
|
ExpirationTimestamp: types.StringValue(now.Format(time.RFC3339)),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"empty_strings",
|
|
&objectstorage.CreateAccessKeyResponse{
|
|
AccessKey: utils.Ptr(""),
|
|
DisplayName: utils.Ptr(""),
|
|
SecretAccessKey: utils.Ptr(""),
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringValue(""),
|
|
AccessKey: types.StringValue(""),
|
|
SecretAccessKey: types.StringValue(""),
|
|
ExpirationTimestamp: types.StringNull(),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"expiration_timestamp_with_fractional_seconds",
|
|
&objectstorage.CreateAccessKeyResponse{
|
|
Expires: utils.Ptr(now.Format(time.RFC3339Nano)),
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringNull(),
|
|
AccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringValue(now.Format(time.RFC3339)),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"nil_response",
|
|
nil,
|
|
Model{},
|
|
false,
|
|
},
|
|
{
|
|
"bad_time",
|
|
&objectstorage.CreateAccessKeyResponse{
|
|
Expires: utils.Ptr("foo-bar"),
|
|
},
|
|
Model{},
|
|
false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
model := &Model{
|
|
ProjectId: tt.expected.ProjectId,
|
|
CredentialsGroupId: tt.expected.CredentialsGroupId,
|
|
CredentialId: tt.expected.CredentialId,
|
|
}
|
|
err := mapFields(tt.input, model, "eu01")
|
|
if !tt.isValid && err == nil {
|
|
t.Fatalf("Should have failed")
|
|
}
|
|
if tt.isValid && err != nil {
|
|
t.Fatalf("Should not have failed: %v", err)
|
|
}
|
|
if tt.isValid {
|
|
diff := cmp.Diff(model, &tt.expected)
|
|
if diff != "" {
|
|
t.Fatalf("Data does not match: %s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestEnableProject(t *testing.T) {
|
|
tests := []struct {
|
|
description string
|
|
expected Model
|
|
enableFails bool
|
|
isValid bool
|
|
}{
|
|
{
|
|
"default_values",
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringNull(),
|
|
AccessKey: types.StringNull(),
|
|
SecretAccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringNull(),
|
|
},
|
|
false,
|
|
true,
|
|
},
|
|
{
|
|
"error_response",
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringNull(),
|
|
AccessKey: types.StringNull(),
|
|
SecretAccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringNull(),
|
|
},
|
|
true,
|
|
false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
client := &objectStorageClientMocked{
|
|
returnError: tt.enableFails,
|
|
}
|
|
model := &Model{
|
|
ProjectId: tt.expected.ProjectId,
|
|
CredentialsGroupId: tt.expected.CredentialsGroupId,
|
|
CredentialId: tt.expected.CredentialId,
|
|
}
|
|
err := enableProject(context.Background(), model, "eu01", client)
|
|
if !tt.isValid && err == nil {
|
|
t.Fatalf("Should have failed")
|
|
}
|
|
if tt.isValid && err != nil {
|
|
t.Fatalf("Should not have failed: %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestReadCredentials(t *testing.T) {
|
|
now := time.Now()
|
|
|
|
tests := []struct {
|
|
description string
|
|
mockedResp *objectstorage.ListAccessKeysResponse
|
|
expectedModel Model
|
|
expectedFound bool
|
|
getCredentialsFails bool
|
|
isValid bool
|
|
}{
|
|
{
|
|
"default_values",
|
|
&objectstorage.ListAccessKeysResponse{
|
|
AccessKeys: &[]objectstorage.AccessKey{
|
|
{
|
|
KeyId: utils.Ptr("foo-cid"),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("bar-cid"),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("cid"),
|
|
},
|
|
},
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringNull(),
|
|
AccessKey: types.StringNull(),
|
|
SecretAccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringNull(),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
false,
|
|
true,
|
|
},
|
|
{
|
|
"simple_values",
|
|
&objectstorage.ListAccessKeysResponse{
|
|
AccessKeys: &[]objectstorage.AccessKey{
|
|
{
|
|
KeyId: utils.Ptr("foo-cid"),
|
|
DisplayName: utils.Ptr("foo-name"),
|
|
Expires: utils.Ptr(now.Add(time.Hour).Format(time.RFC3339)),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("bar-cid"),
|
|
DisplayName: utils.Ptr("bar-name"),
|
|
Expires: utils.Ptr(now.Add(time.Minute).Format(time.RFC3339)),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("cid"),
|
|
DisplayName: utils.Ptr("name"),
|
|
Expires: utils.Ptr(now.Format(time.RFC3339)),
|
|
},
|
|
},
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringValue("name"),
|
|
AccessKey: types.StringNull(),
|
|
SecretAccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringValue(now.Format(time.RFC3339)),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
false,
|
|
true,
|
|
},
|
|
{
|
|
"expiration_timestamp_with_fractional_seconds",
|
|
&objectstorage.ListAccessKeysResponse{
|
|
AccessKeys: &[]objectstorage.AccessKey{
|
|
{
|
|
KeyId: utils.Ptr("foo-cid"),
|
|
DisplayName: utils.Ptr("foo-name"),
|
|
Expires: utils.Ptr(now.Add(time.Hour).Format(time.RFC3339Nano)),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("bar-cid"),
|
|
DisplayName: utils.Ptr("bar-name"),
|
|
Expires: utils.Ptr(now.Add(time.Minute).Format(time.RFC3339Nano)),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("cid"),
|
|
DisplayName: utils.Ptr("name"),
|
|
Expires: utils.Ptr(now.Format(time.RFC3339Nano)),
|
|
},
|
|
},
|
|
},
|
|
Model{
|
|
Id: types.StringValue("pid,cgid,cid"),
|
|
ProjectId: types.StringValue("pid"),
|
|
CredentialsGroupId: types.StringValue("cgid"),
|
|
CredentialId: types.StringValue("cid"),
|
|
Name: types.StringValue("name"),
|
|
AccessKey: types.StringNull(),
|
|
SecretAccessKey: types.StringNull(),
|
|
ExpirationTimestamp: types.StringValue(now.Format(time.RFC3339)),
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
true,
|
|
false,
|
|
true,
|
|
},
|
|
{
|
|
"empty_credentials",
|
|
&objectstorage.ListAccessKeysResponse{
|
|
AccessKeys: &[]objectstorage.AccessKey{},
|
|
},
|
|
Model{
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
false,
|
|
false,
|
|
true,
|
|
},
|
|
{
|
|
"nil_response",
|
|
nil,
|
|
Model{},
|
|
false,
|
|
false,
|
|
false,
|
|
},
|
|
{
|
|
"non_matching_credential",
|
|
&objectstorage.ListAccessKeysResponse{
|
|
AccessKeys: &[]objectstorage.AccessKey{
|
|
{
|
|
KeyId: utils.Ptr("foo-cid"),
|
|
DisplayName: utils.Ptr("foo-name"),
|
|
Expires: utils.Ptr(now.Add(time.Hour).Format(time.RFC3339)),
|
|
},
|
|
{
|
|
KeyId: utils.Ptr("bar-cid"),
|
|
DisplayName: utils.Ptr("bar-name"),
|
|
Expires: utils.Ptr(now.Add(time.Minute).Format(time.RFC3339)),
|
|
},
|
|
},
|
|
},
|
|
Model{
|
|
Region: types.StringValue("eu01"),
|
|
},
|
|
false,
|
|
false,
|
|
true,
|
|
},
|
|
{
|
|
"error_response",
|
|
&objectstorage.ListAccessKeysResponse{
|
|
AccessKeys: &[]objectstorage.AccessKey{
|
|
{
|
|
KeyId: utils.Ptr("cid"),
|
|
DisplayName: utils.Ptr("name"),
|
|
Expires: utils.Ptr(now.Format(time.RFC3339)),
|
|
},
|
|
},
|
|
},
|
|
Model{},
|
|
false,
|
|
true,
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
mockedRespBytes, err := json.Marshal(tt.mockedResp)
|
|
if err != nil {
|
|
t.Fatalf("Failed to marshal mocked response: %v", err)
|
|
}
|
|
|
|
handler := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
if tt.getCredentialsFails {
|
|
w.WriteHeader(http.StatusBadGateway)
|
|
w.Header().Set("Content-Type", "application/json")
|
|
_, err := w.Write([]byte("{\"message\": \"Something bad happened\""))
|
|
if err != nil {
|
|
t.Errorf("Failed to write bad response: %v", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
_, err := w.Write(mockedRespBytes)
|
|
if err != nil {
|
|
t.Errorf("Failed to write response: %v", err)
|
|
}
|
|
})
|
|
mockedServer := httptest.NewServer(handler)
|
|
defer mockedServer.Close()
|
|
client, err := objectstorage.NewAPIClient(
|
|
config.WithEndpoint(mockedServer.URL),
|
|
config.WithoutAuthentication(),
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("Failed to initialize client: %v", err)
|
|
}
|
|
|
|
model := &Model{
|
|
ProjectId: tt.expectedModel.ProjectId,
|
|
CredentialsGroupId: tt.expectedModel.CredentialsGroupId,
|
|
CredentialId: tt.expectedModel.CredentialId,
|
|
}
|
|
found, err := readCredentials(context.Background(), model, "eu01", client)
|
|
if !tt.isValid && err == nil {
|
|
t.Fatalf("Should have failed")
|
|
}
|
|
if tt.isValid && err != nil {
|
|
t.Fatalf("Should not have failed: %v", err)
|
|
}
|
|
if tt.isValid {
|
|
diff := cmp.Diff(model, &tt.expectedModel)
|
|
if diff != "" {
|
|
t.Fatalf("Data does not match: %s", diff)
|
|
}
|
|
|
|
if found != tt.expectedFound {
|
|
t.Fatalf("Found does not match: %v", found)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|