stackit-dev-tools/terraform-provider-stackitprivatepreview
3
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix(alertgroups): add expression validator to detect new lines on expressions (#807)

Browse source
This commit is contained in:
Mauritz Uphoff 2025-05-07 11:54:54 +02:00 • committed by GitHub
parent 9cd402e09f
commit f4498e85f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 111 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
stackit/internal/services/observability/alertgroup/resource.go
View file

@ -207,6 +207,10 @@ func (a *alertGroupResource) Schema(_ context.Context, _ resource.SchemaRequest,
Required: true,
Validators: []validator.String{
stringvalidator.LengthBetween(1, 600),
// The API currently accepts expressions with trailing newlines but does not return them,
// leading to inconsistent Terraform results. This issue has been reported to the Obs team.
// Until it is resolved, we proactively notify users if their input contains a trailing newline.
validate.ValidNoTrailingNewline(),
},
},
"for": schema.StringAttribute{

4
stackit/internal/services/observability/log-alertgroup/resource.go
View file

@ -207,6 +207,10 @@ func (l *logAlertGroupResource) Schema(_ context.Context, _ resource.SchemaReque
Required: true,
Validators: []validator.String{
stringvalidator.LengthBetween(1, 600),
// The API currently accepts expressions with trailing newlines but does not return them,
// leading to inconsistent Terraform results. This issue has been reported to the Obs team.
// Until it is resolved, we proactively notify users if their input contains a trailing newline.
validate.ValidNoTrailingNewline(),
},
},
"for": schema.StringAttribute{

2
stackit/internal/services/ske/cluster/resource.go
View file

@ -997,7 +997,7 @@ func toNodepoolsPayload(ctx context.Context, m *Model, availableMachineVersions
if v.IsNull() || v.IsUnknown() {
continue
}
s, err := conversion.ToString(context.TODO(), v)
s, err := conversion.ToString(ctx, v)
if err != nil {
continue
}