stackit-dev-tools/terraform-provider-stackitprivatepreview
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SKE Acc tests - Remove max_surge from min cluster (#130)

Browse source 
* Remove max_surge

* Simplify import

---------

Co-authored-by: Henrique Santos <henrique.santos@freiheit.com>
This commit is contained in:
Henrique Santos 2023-11-07 11:27:43 +00:00 • committed by GitHub
parent 4728a49845
commit cbbf3a00c5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
stackit/internal/services/ske/ske_acc_test.go
View file

@ -10,7 +10,7 @@ import (
"github.com/hashicorp/terraform-plugin-testing/helper/resource" "github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/terraform" "github.com/hashicorp/terraform-plugin-testing/terraform"
"github.com/stackitcloud/stackit-sdk-go/core/config" "github.com/stackitcloud/stackit-sdk-go/core/config"
oapiError "github.com/stackitcloud/stackit-sdk-go/core/oapierror" "github.com/stackitcloud/stackit-sdk-go/core/oapierror"
"github.com/stackitcloud/stackit-sdk-go/core/utils" "github.com/stackitcloud/stackit-sdk-go/core/utils"
"github.com/stackitcloud/stackit-sdk-go/services/ske" "github.com/stackitcloud/stackit-sdk-go/services/ske"
"github.com/stackitcloud/stackit-sdk-go/services/ske/wait" "github.com/stackitcloud/stackit-sdk-go/services/ske/wait"
@ -143,7 +143,6 @@ func getConfig(version string, apc *bool, maintenanceEnd *string) string {
os_version = "%s" os_version = "%s"
minimum = "%s" minimum = "%s"
maximum = "%s" maximum = "%s"
max_surge = "%s"
availability_zones = ["%s"] availability_zones = ["%s"]
}] }]
maintenance = { maintenance = {
@ -196,7 +195,6 @@ func getConfig(version string, apc *bool, maintenanceEnd *string) string {
clusterResource["nodepool_os_version_min"], clusterResource["nodepool_os_version_min"],
clusterResource["nodepool_minimum"], clusterResource["nodepool_minimum"],
clusterResource["nodepool_maximum"], clusterResource["nodepool_maximum"],
clusterResource["nodepool_max_surge"],
clusterResource["nodepool_zone"], clusterResource["nodepool_zone"],
clusterResource["maintenance_enable_kubernetes_version_updates"], clusterResource["maintenance_enable_kubernetes_version_updates"],
clusterResource["maintenance_enable_machine_image_version_updates"], clusterResource["maintenance_enable_machine_image_version_updates"],
@ -531,7 +529,7 @@ func testAccCheckSKEDestroy(s *terraform.State) error {
for _, projectId := range projectsToDestroy { for _, projectId := range projectsToDestroy {
_, err := client.GetProject(ctx, projectId).Execute() _, err := client.GetProject(ctx, projectId).Execute()
if err != nil { if err != nil {
oapiErr, ok := err.(*oapiError.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped
if !ok { if !ok {
return fmt.Errorf("could not convert error to GenericOpenApiError in acc test destruction, %w", err) return fmt.Errorf("could not convert error to GenericOpenApiError in acc test destruction, %w", err)
} }