stackit-dev-tools/terraform-provider-stackitprivatepreview
2
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix(ske): read only attributes produces noise (#1081)

Browse source 
* fix(ske): read-only attributes produces noise

* feat: add new planmodifier `UseStateForUnknownIf`
This commit is contained in:
Marcel Jacek 2025-12-04 13:32:18 +01:00 • committed by GitHub
parent 06747751ca
commit 8a609d4ab8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 249 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

52
stackit/internal/services/ske/cluster/resource.go
View file

@ -368,6 +368,9 @@ func (r *clusterResource) Schema(_ context.Context, _ resource.SchemaRequest, re
"kubernetes_version_used": schema.StringAttribute{
Description: "Full Kubernetes version used. For example, if 1.22 was set in `kubernetes_version_min`, this value may result to 1.22.15. " + SKEUpdateDoc,
Computed: true,
PlanModifiers: []planmodifier.String{
utils.UseStateForUnknownIf(hasKubernetesMinChanged, "sets `UseStateForUnknown` only if `kubernetes_min_version` has not changed"),
},
},
"egress_address_ranges": schema.ListAttribute{
Description: "The outgoing network ranges (in CIDR notation) of traffic originating from workload on the cluster.",
@ -454,6 +457,9 @@ func (r *clusterResource) Schema(_ context.Context, _ resource.SchemaRequest, re
"os_version_used": schema.StringAttribute{
Description: "Full OS image version used. For example, if 3815.2 was set in `os_version_min`, this value may result to 3815.2.2. " + SKEUpdateDoc,
Computed: true,
PlanModifiers: []planmodifier.String{
utils.UseStateForUnknownIf(hasOsVersionMinChanged, "sets `UseStateForUnknown` only if `os_version_min` has not changed"),
},
},
"volume_type": schema.StringAttribute{
Description: "Specifies the volume type. Defaults to `storage_premium_perf1`.",
@ -2105,6 +2111,52 @@ func getLatestSupportedKubernetesVersion(versions []ske.KubernetesVersion) (*str
return latestVersion, nil
}
func hasKubernetesMinChanged(ctx context.Context, request planmodifier.StringRequest, response *utils.UseStateForUnknownFuncResponse) { // nolint:gocritic // function signature required by Terraform
dependencyPath := path.Root("kubernetes_version_min")
var minVersionPlan types.String
diags := request.Plan.GetAttribute(ctx, dependencyPath, &minVersionPlan)
response.Diagnostics.Append(diags...)
if response.Diagnostics.HasError() {
return
}
var minVersionState types.String
diags = request.State.GetAttribute(ctx, dependencyPath, &minVersionState)
response.Diagnostics.Append(diags...)
if response.Diagnostics.HasError() {
return
}
if minVersionState == minVersionPlan {
response.UseStateForUnknown = true
return
}
}
func hasOsVersionMinChanged(ctx context.Context, request planmodifier.StringRequest, response *utils.UseStateForUnknownFuncResponse) { // nolint:gocritic // function signature required by Terraform
dependencyPath := request.Path.ParentPath().AtName("os_version_min")
var minVersionPlan types.String
diags := request.Plan.GetAttribute(ctx, dependencyPath, &minVersionPlan)
response.Diagnostics.Append(diags...)
if response.Diagnostics.HasError() {
return
}
var minVersionState types.String
diags = request.State.GetAttribute(ctx, dependencyPath, &minVersionState)
response.Diagnostics.Append(diags...)
if response.Diagnostics.HasError() {
return
}
if minVersionState == minVersionPlan {
response.UseStateForUnknown = true
return
}
}
func (r *clusterResource) Read(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) { // nolint:gocritic // function signature required by Terraform
var state Model
diags := req.State.Get(ctx, &state)