fix: clean up code

stackit/internal/core/core.go

@@ -32,7 +32,7 @@ const (
 type EphemeralProviderData struct {
 	ProviderData
 
-	PrivateKey            string
+	PrivateKey            string //nolint:gosec //this is a placeholder and not used in this code
 	PrivateKeyPath        string
 	ServiceAccountKey     string
 	ServiceAccountKeyPath string
@@ -105,11 +105,13 @@ func DiagsToError(diags diag.Diagnostics) error {
 	diagsError := diags.Errors()
 	diagsStrings := make([]string, 0)
 	for _, diagnostic := range diagsError {
-		diagsStrings = append(diagsStrings, fmt.Sprintf(
-			"(%s) %s",
-			diagnostic.Summary(),
-			diagnostic.Detail(),
-		))
+		diagsStrings = append(
+			diagsStrings, fmt.Sprintf(
+				"(%s) %s",
+				diagnostic.Summary(),
+				diagnostic.Detail(),
+			),
+		)
 	}
 	return fmt.Errorf("%s", strings.Join(diagsStrings, ";"))
 }
@@ -136,14 +138,22 @@ func LogAndAddWarning(ctx context.Context, diags *diag.Diagnostics, summary, det
 
 func LogAndAddWarningBeta(ctx context.Context, diags *diag.Diagnostics, name string, resourceType ResourceType) {
 	warnTitle := fmt.Sprintf("The %s %q is in beta", resourceType, name)
-	warnContent := fmt.Sprintf("The %s %q is in beta and may be subject to breaking changes in the future. Use with caution.", resourceType, name)
+	warnContent := fmt.Sprintf(
+		"The %s %q is in beta and may be subject to breaking changes in the future. Use with caution.",
+		resourceType,
+		name,
+	)
 	tflog.Warn(ctx, fmt.Sprintf("%s | %s", warnTitle, warnContent))
 	diags.AddWarning(warnTitle, warnContent)
 }
 
 func LogAndAddErrorBeta(ctx context.Context, diags *diag.Diagnostics, name string, resourceType ResourceType) {
 	errTitle := fmt.Sprintf("The %s %q is in beta and beta is not enabled", resourceType, name)
-	errContent := fmt.Sprintf(`The %s %q is in beta and the beta functionality is currently not enabled. To enable it, set the environment variable STACKIT_TF_ENABLE_BETA_RESOURCES to "true" or set the "enable_beta_resources" provider field to true.`, resourceType, name)
+	errContent := fmt.Sprintf(
+		`The %s %q is in beta and the beta functionality is currently not enabled. To enable it, set the environment variable STACKIT_TF_ENABLE_BETA_RESOURCES to "true" or set the "enable_beta_resources" provider field to true.`,
+		resourceType,
+		name,
+	)
 	tflog.Error(ctx, fmt.Sprintf("%s | %s", errTitle, errContent))
 	diags.AddError(errTitle, errContent)
 }
@@ -161,8 +171,10 @@ func LogResponse(ctx context.Context) context.Context {
 	traceId := runtime.GetTraceId(ctx)
 	ctx = tflog.SetField(ctx, "x-trace-id", traceId)
 
-	tflog.Info(ctx, "response data", map[string]interface{}{
-		"x-trace-id": traceId,
-	})
+	tflog.Info(
+		ctx, "response data", map[string]interface{}{
+			"x-trace-id": traceId,
+		},
+	)
 	return ctx
 }

stackit/internal/core/retry_round_tripper.go

@@ -98,7 +98,7 @@ func (rrt *RetryRoundTripper) retryLoop(
 
 		waitDuration := rrt.calculateWaitDurationWithJitter(ctx, currentDelay)
 		if err := rrt.waitForDelay(ctx, waitDuration); err != nil {
-			return nil, err // Context was cancelled during wait.
+			return nil, err // Context was canceled during wait.
 		}
 
 		// Exponential backoff for the next potential retry.
@@ -153,7 +153,6 @@ func (rrt *RetryRoundTripper) handleFinalError(
 ) error {
 	if resp != nil {
 		if err := resp.Body.Close(); err != nil {
-
 			tflog.Warn(
 				ctx, "Failed to close response body", map[string]interface{}{
 					"error": err.Error(),
@@ -194,7 +193,6 @@ func (rrt *RetryRoundTripper) shouldRetry(resp *http.Response, err error) bool {
 	}
 
 	return false
-
 }
 
 // calculateWaitDurationWithJitter calculates the backoff duration for the next retry,
@@ -232,7 +230,7 @@ func (rrt *RetryRoundTripper) calculateWaitDurationWithJitter(
 func (rrt *RetryRoundTripper) waitForDelay(ctx context.Context, delay time.Duration) error {
 	select {
 	case <-ctx.Done():
-		return fmt.Errorf("context cancelled during backoff wait: %w", ctx.Err())
+		return fmt.Errorf("context canceled during backoff wait: %w", ctx.Err())
 	case <-time.After(delay):
 		return nil
 	}

stackit/internal/core/retry_round_tripper_test.go

@@ -72,7 +72,7 @@ func TestRetryRoundTripper_RoundTrip(t *testing.T) {
 					},
 				}
 				tripper := testRetryConfig(mock)
-				req := httptest.NewRequest(http.MethodGet, "/", nil)
+				req := httptest.NewRequest(http.MethodGet, "/", http.NoBody)
 
 				resp, err := tripper.RoundTrip(req)
 				if resp != nil {
@@ -110,7 +110,7 @@ func TestRetryRoundTripper_RoundTrip(t *testing.T) {
 				},
 			}
 			tripper := testRetryConfig(mock)
-			req := httptest.NewRequest(http.MethodGet, "/", nil)
+			req := httptest.NewRequest(http.MethodGet, "/", http.NoBody)
 
 			resp, err := tripper.RoundTrip(req)
 			if resp != nil {
@@ -155,7 +155,7 @@ func TestRetryRoundTripper_RoundTrip(t *testing.T) {
 				}, nil
 			}
 			tripper := testRetryConfig(mock)
-			req := httptest.NewRequest(http.MethodGet, "/", nil)
+			req := httptest.NewRequest(http.MethodGet, "/", http.NoBody)
 
 			resp, err := tripper.RoundTrip(req)
 			if resp != nil {
@@ -185,12 +185,12 @@ func TestRetryRoundTripper_RoundTrip(t *testing.T) {
 			mockErr := errors.New("simulated network error")
 
 			mock := &mockRoundTripper{
-				roundTripFunc: func(req *http.Request) (*http.Response, error) {
+				roundTripFunc: func(_ *http.Request) (*http.Response, error) {
 					return nil, mockErr
 				},
 			}
 			tripper := testRetryConfig(mock)
-			req := httptest.NewRequest(http.MethodGet, "/", nil)
+			req := httptest.NewRequest(http.MethodGet, "/", http.NoBody)
 
 			resp, err := tripper.RoundTrip(req)
 			if resp != nil {
@@ -211,7 +211,7 @@ func TestRetryRoundTripper_RoundTrip(t *testing.T) {
 	)
 
 	t.Run(
-		"should abort retries if the main context is cancelled", func(t *testing.T) {
+		"should abort retries if the main context is canceled", func(t *testing.T) {
 			t.Parallel()
 
 			mock := &mockRoundTripper{
@@ -230,7 +230,7 @@ func TestRetryRoundTripper_RoundTrip(t *testing.T) {
 			ctx, cancel := context.WithTimeout(baseCtx, 20*time.Millisecond)
 			defer cancel()
 
-			req := httptest.NewRequest(http.MethodGet, "/", nil).WithContext(ctx)
+			req := httptest.NewRequest(http.MethodGet, "/", http.NoBody).WithContext(ctx)
 
 			resp, err := tripper.RoundTrip(req)
 			if resp != nil {