fix: fix sqlserverflexalpha (#61)

## Description

<!-- **Please link some issue here describing what you are trying to achieve.**

In case there is no issue present for your PR, please consider creating one.
At least please give us some description what you are trying to achieve and why your change is needed. -->

relates to #1234

## Checklist

- [ ] Issue was linked above
- [ ] Code format was applied: `make fmt`
- [ ] Examples were added / adjusted (see `examples/` directory)
- [x] Docs are up-to-date: `make generate-docs` (will be checked by CI)
- [ ] Unit tests got implemented or updated
- [ ] Acceptance tests got implemented or updated (see e.g. [here](f5f99d1709/stackit/internal/services/dns/dns_acc_test.go))
- [x] Unit tests are passing: `make test` (will be checked by CI)
- [x] No linter issues: `make lint` (will be checked by CI)

Reviewed-on: #61
Co-authored-by: Marcel S. Henselin <marcel.henselin@stackit.cloud>
Co-committed-by: Marcel S. Henselin <marcel.henselin@stackit.cloud>

stackit/internal/services/sqlserverflexalpha/instance/functions.go

@@ -2,6 +2,7 @@ package sqlserverflexalpha
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"math"
 
@@ -10,29 +11,35 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
-	sqlserverflex "tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/pkg_gen/sqlserverflexalpha"
+	"tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/pkg_gen/sqlserverflexalpha"
 	"tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/stackit/internal/conversion"
-	sqlserverflexResGen "tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/stackit/internal/services/sqlserverflexalpha/instance/resources_gen"
+	sqlserverflexalphaDataGen "tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/stackit/internal/services/sqlserverflexalpha/instance/datasources_gen"
+	sqlserverflexalphaResGen "tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/stackit/internal/services/sqlserverflexalpha/instance/resources_gen"
 )
 
-// instanceModel is a type constraint for models that can be mapped from a GetInstanceResponse.
-type instanceModel interface {
-	*dataSourceModel | *resourceModel
-}
-
-func mapFields[T instanceModel](
+func mapResponseToModel(
 	ctx context.Context,
-	resp *sqlserverflex.GetInstanceResponse,
-	m T,
+	resp *sqlserverflexalpha.GetInstanceResponse,
+	m *sqlserverflexalphaResGen.InstanceModel,
 	tfDiags diag.Diagnostics,
 ) error {
+	m.BackupSchedule = types.StringValue(resp.GetBackupSchedule())
+	m.Edition = types.StringValue(string(resp.GetEdition()))
+	m.Encryption = handleEncryption(m, resp)
+	m.FlavorId = types.StringValue(resp.GetFlavorId())
+	m.Id = types.StringValue(resp.GetId())
+	m.InstanceId = types.StringValue(resp.GetId())
+	m.IsDeletable = types.BoolValue(resp.GetIsDeletable())
+	m.Name = types.StringValue(resp.GetName())
 	netAcl, diags := types.ListValueFrom(ctx, types.StringType, resp.Network.GetAcl())
 	tfDiags.Append(diags...)
 	if diags.HasError() {
-		return fmt.Errorf("error converting network acl response value")
+		return fmt.Errorf(
+			"error converting network acl response value",
+		)
 	}
-	net, diags := sqlserverflexResGen.NewNetworkValue(
-		sqlserverflexResGen.NetworkValue{}.AttributeTypes(ctx),
+	net, diags := sqlserverflexalphaResGen.NewNetworkValue(
+		sqlserverflexalphaResGen.NetworkValue{}.AttributeTypes(ctx),
 		map[string]attr.Value{
 			"access_scope":     types.StringValue(string(resp.Network.GetAccessScope())),
 			"acl":              netAcl,
@@ -42,11 +49,15 @@ func mapFields[T instanceModel](
 	)
 	tfDiags.Append(diags...)
 	if diags.HasError() {
-		return fmt.Errorf("error converting network response value")
+		return errors.New("error converting network response value")
 	}
+	m.Network = net
+	m.Replicas = types.Int64Value(int64(resp.GetReplicas()))
+	m.RetentionDays = types.Int64Value(resp.GetRetentionDays())
+	m.Status = types.StringValue(string(resp.GetStatus()))
 
-	stor, diags := sqlserverflexResGen.NewStorageValue(
-		sqlserverflexResGen.StorageValue{}.AttributeTypes(ctx),
+	stor, diags := sqlserverflexalphaResGen.NewStorageValue(
+		sqlserverflexalphaResGen.StorageValue{}.AttributeTypes(ctx),
 		map[string]attr.Value{
 			"class": types.StringValue(resp.Storage.GetClass()),
 			"size":  types.Int64Value(resp.Storage.GetSize()),
@@ -56,62 +67,117 @@ func mapFields[T instanceModel](
 	if diags.HasError() {
 		return fmt.Errorf("error converting storage response value")
 	}
+	m.Storage = stor
 
-	// The interface conversion is safe due to the type constraint.
-	model := any(m)
+	m.Version = types.StringValue(string(resp.GetVersion()))
+	return nil
+}
 
-	if rm, ok := model.(*resourceModel); ok {
-		rm.BackupSchedule = types.StringValue(resp.GetBackupSchedule())
-		rm.Edition = types.StringValue(string(resp.GetEdition()))
-		rm.Encryption = handleEncryption(rm.Encryption, resp)
-		rm.FlavorId = types.StringValue(resp.GetFlavorId())
-		rm.Id = types.StringValue(resp.GetId())
-		rm.InstanceId = types.StringValue(resp.GetId())
-		rm.IsDeletable = types.BoolValue(resp.GetIsDeletable())
-		rm.Name = types.StringValue(resp.GetName())
-		rm.Network = net
-		rm.Replicas = types.Int64Value(int64(resp.GetReplicas()))
-		rm.RetentionDays = types.Int64Value(resp.GetRetentionDays())
-		rm.Status = types.StringValue(string(resp.GetStatus()))
-		rm.Storage = stor
-		rm.Version = types.StringValue(string(resp.GetVersion()))
-	} else if dm, ok := model.(*dataSourceModel); ok {
-		dm.BackupSchedule = types.StringValue(resp.GetBackupSchedule())
-		dm.Edition = types.StringValue(string(resp.GetEdition()))
-		dm.Encryption = handleEncryption(dm.Encryption, resp)
-		dm.FlavorId = types.StringValue(resp.GetFlavorId())
-		dm.Id = types.StringValue(resp.GetId())
-		dm.InstanceId = types.StringValue(resp.GetId())
-		dm.IsDeletable = types.BoolValue(resp.GetIsDeletable())
-		dm.Name = types.StringValue(resp.GetName())
-		dm.Network = net
-		dm.Replicas = types.Int64Value(int64(resp.GetReplicas()))
-		dm.RetentionDays = types.Int64Value(resp.GetRetentionDays())
-		dm.Status = types.StringValue(string(resp.GetStatus()))
-		dm.Storage = stor
-		dm.Version = types.StringValue(string(resp.GetVersion()))
+func mapDataResponseToModel(
+	ctx context.Context,
+	resp *sqlserverflexalpha.GetInstanceResponse,
+	m *dataSourceModel,
+	tfDiags diag.Diagnostics,
+) error {
+	m.BackupSchedule = types.StringValue(resp.GetBackupSchedule())
+	m.Edition = types.StringValue(string(resp.GetEdition()))
+	m.Encryption = handleDSEncryption(m, resp)
+	m.FlavorId = types.StringValue(resp.GetFlavorId())
+	m.Id = types.StringValue(resp.GetId())
+	m.InstanceId = types.StringValue(resp.GetId())
+	m.IsDeletable = types.BoolValue(resp.GetIsDeletable())
+	m.Name = types.StringValue(resp.GetName())
+	netAcl, diags := types.ListValueFrom(ctx, types.StringType, resp.Network.GetAcl())
+	tfDiags.Append(diags...)
+	if diags.HasError() {
+		return fmt.Errorf(
+			"error converting network acl response value",
+		)
 	}
+	net, diags := sqlserverflexalphaDataGen.NewNetworkValue(
+		sqlserverflexalphaDataGen.NetworkValue{}.AttributeTypes(ctx),
+		map[string]attr.Value{
+			"access_scope":     types.StringValue(string(resp.Network.GetAccessScope())),
+			"acl":              netAcl,
+			"instance_address": types.StringValue(resp.Network.GetInstanceAddress()),
+			"router_address":   types.StringValue(resp.Network.GetRouterAddress()),
+		},
+	)
+	tfDiags.Append(diags...)
+	if diags.HasError() {
+		return errors.New("error converting network response value")
+	}
+	m.Network = net
+	m.Replicas = types.Int64Value(int64(resp.GetReplicas()))
+	m.RetentionDays = types.Int64Value(resp.GetRetentionDays())
+	m.Status = types.StringValue(string(resp.GetStatus()))
 
+	stor, diags := sqlserverflexalphaDataGen.NewStorageValue(
+		sqlserverflexalphaDataGen.StorageValue{}.AttributeTypes(ctx),
+		map[string]attr.Value{
+			"class": types.StringValue(resp.Storage.GetClass()),
+			"size":  types.Int64Value(resp.Storage.GetSize()),
+		},
+	)
+	tfDiags.Append(diags...)
+	if diags.HasError() {
+		return fmt.Errorf("error converting storage response value")
+	}
+	m.Storage = stor
+
+	m.Version = types.StringValue(string(resp.GetVersion()))
 	return nil
 }
 
 func handleEncryption(
-	encryptionValue sqlserverflexResGen.EncryptionValue,
-	resp *sqlserverflex.GetInstanceResponse,
-) sqlserverflexResGen.EncryptionValue {
+	m *sqlserverflexalphaResGen.InstanceModel,
+	resp *sqlserverflexalpha.GetInstanceResponse,
+) sqlserverflexalphaResGen.EncryptionValue {
 	if !resp.HasEncryption() ||
 		resp.Encryption == nil ||
 		resp.Encryption.KekKeyId == nil ||
 		resp.Encryption.KekKeyRingId == nil ||
 		resp.Encryption.KekKeyVersion == nil ||
 		resp.Encryption.ServiceAccount == nil {
-		if encryptionValue.IsNull() || encryptionValue.IsUnknown() {
-			return sqlserverflexResGen.NewEncryptionValueNull()
+		if m.Encryption.IsNull() || m.Encryption.IsUnknown() {
+			return sqlserverflexalphaResGen.NewEncryptionValueNull()
 		}
-		return encryptionValue
+		return m.Encryption
 	}
 
-	enc := sqlserverflexResGen.NewEncryptionValueNull()
+	enc := sqlserverflexalphaResGen.NewEncryptionValueNull()
+	if kVal, ok := resp.Encryption.GetKekKeyIdOk(); ok {
+		enc.KekKeyId = types.StringValue(kVal)
+	}
+	if kkVal, ok := resp.Encryption.GetKekKeyRingIdOk(); ok {
+		enc.KekKeyRingId = types.StringValue(kkVal)
+	}
+	if kkvVal, ok := resp.Encryption.GetKekKeyVersionOk(); ok {
+		enc.KekKeyVersion = types.StringValue(kkvVal)
+	}
+	if sa, ok := resp.Encryption.GetServiceAccountOk(); ok {
+		enc.ServiceAccount = types.StringValue(sa)
+	}
+	return enc
+}
+
+func handleDSEncryption(
+	m *dataSourceModel,
+	resp *sqlserverflexalpha.GetInstanceResponse,
+) sqlserverflexalphaDataGen.EncryptionValue {
+	if !resp.HasEncryption() ||
+		resp.Encryption == nil ||
+		resp.Encryption.KekKeyId == nil ||
+		resp.Encryption.KekKeyRingId == nil ||
+		resp.Encryption.KekKeyVersion == nil ||
+		resp.Encryption.ServiceAccount == nil {
+		if m.Encryption.IsNull() || m.Encryption.IsUnknown() {
+			return sqlserverflexalphaDataGen.NewEncryptionValueNull()
+		}
+		return m.Encryption
+	}
+
+	enc := sqlserverflexalphaDataGen.NewEncryptionValueNull()
 	if kVal, ok := resp.Encryption.GetKekKeyIdOk(); ok {
 		enc.KekKeyId = types.StringValue(kVal)
 	}
@@ -129,25 +195,25 @@ func handleEncryption(
 
 func toCreatePayload(
 	ctx context.Context,
-	model *sqlserverflexResGen.InstanceModel,
-) (*sqlserverflex.CreateInstanceRequestPayload, error) {
+	model *sqlserverflexalphaResGen.InstanceModel,
+) (*sqlserverflexalpha.CreateInstanceRequestPayload, error) {
 	if model == nil {
 		return nil, fmt.Errorf("nil model")
 	}
 
-	storagePayload := &sqlserverflex.CreateInstanceRequestPayloadGetStorageArgType{}
+	storagePayload := &sqlserverflexalpha.CreateInstanceRequestPayloadGetStorageArgType{}
 	if !model.Storage.IsNull() && !model.Storage.IsUnknown() {
 		storagePayload.Class = model.Storage.Class.ValueStringPointer()
 		storagePayload.Size = model.Storage.Size.ValueInt64Pointer()
 	}
 
-	var encryptionPayload *sqlserverflex.CreateInstanceRequestPayloadGetEncryptionArgType = nil
+	var encryptionPayload *sqlserverflexalpha.CreateInstanceRequestPayloadGetEncryptionArgType = nil
 	if !model.Encryption.IsNull() && !model.Encryption.IsUnknown() &&
 		!model.Encryption.KekKeyId.IsNull() && model.Encryption.KekKeyId.IsUnknown() && model.Encryption.KekKeyId.ValueString() != "" &&
 		!model.Encryption.KekKeyRingId.IsNull() && !model.Encryption.KekKeyRingId.IsUnknown() && model.Encryption.KekKeyRingId.ValueString() != "" &&
 		!model.Encryption.KekKeyVersion.IsNull() && !model.Encryption.KekKeyVersion.IsUnknown() && model.Encryption.KekKeyVersion.ValueString() != "" &&
 		!model.Encryption.ServiceAccount.IsNull() && !model.Encryption.ServiceAccount.IsUnknown() && model.Encryption.ServiceAccount.ValueString() != "" {
-		encryptionPayload = &sqlserverflex.CreateInstanceRequestPayloadGetEncryptionArgType{
+		encryptionPayload = &sqlserverflexalpha.CreateInstanceRequestPayloadGetEncryptionArgType{
 			KekKeyId:       model.Encryption.KekKeyId.ValueStringPointer(),
 			KekKeyRingId:   model.Encryption.KekKeyVersion.ValueStringPointer(),
 			KekKeyVersion:  model.Encryption.KekKeyRingId.ValueStringPointer(),
@@ -155,9 +221,9 @@ func toCreatePayload(
 		}
 	}
 
-	networkPayload := &sqlserverflex.CreateInstanceRequestPayloadGetNetworkArgType{}
+	networkPayload := &sqlserverflexalpha.CreateInstanceRequestPayloadGetNetworkArgType{}
 	if !model.Network.IsNull() && !model.Network.IsUnknown() {
-		networkPayload.AccessScope = sqlserverflex.CreateInstanceRequestPayloadNetworkGetAccessScopeAttributeType(
+		networkPayload.AccessScope = sqlserverflexalpha.CreateInstanceRequestPayloadNetworkGetAccessScopeAttributeType(
 			model.Network.AccessScope.ValueStringPointer(),
 		)
 
@@ -169,7 +235,7 @@ func toCreatePayload(
 		networkPayload.Acl = &resList
 	}
 
-	return &sqlserverflex.CreateInstanceRequestPayload{
+	return &sqlserverflexalpha.CreateInstanceRequestPayload{
 		BackupSchedule: conversion.StringValueToPointer(model.BackupSchedule),
 		Encryption:     encryptionPayload,
 		FlavorId:       conversion.StringValueToPointer(model.FlavorId),
@@ -177,20 +243,25 @@ func toCreatePayload(
 		Network:        networkPayload,
 		RetentionDays:  conversion.Int64ValueToPointer(model.RetentionDays),
 		Storage:        storagePayload,
-		Version:        sqlserverflex.CreateInstanceRequestPayloadGetVersionAttributeType(conversion.StringValueToPointer(model.Version)),
+		Version: sqlserverflexalpha.CreateInstanceRequestPayloadGetVersionAttributeType(
+			conversion.StringValueToPointer(model.Version),
+		),
 	}, nil
+
 }
 
-// TODO: check func with his args
 func toUpdatePayload(
 	ctx context.Context,
-	m *sqlserverflexResGen.InstanceModel,
+	m *sqlserverflexalphaResGen.InstanceModel,
 	resp *resource.UpdateResponse,
-) (*sqlserverflex.UpdateInstanceRequestPayload, error) {
+) (*sqlserverflexalpha.UpdateInstanceRequestPayload, error) {
+	if m == nil {
+		return nil, fmt.Errorf("nil model")
+	}
 	if m.Replicas.ValueInt64() > math.MaxUint32 {
 		return nil, fmt.Errorf("replicas value is too big for uint32")
 	}
-	replVal := sqlserverflex.Replicas(uint32(m.Replicas.ValueInt64())) // nolint:gosec // check is performed above
+	replVal := sqlserverflexalpha.Replicas(uint32(m.Replicas.ValueInt64())) // nolint:gosec // check is performed above
 
 	var netAcl []string
 	diags := m.Network.Acl.ElementsAs(ctx, &netAcl, false)
@@ -198,16 +269,16 @@ func toUpdatePayload(
 	if diags.HasError() {
 		return nil, fmt.Errorf("error converting model network acl value")
 	}
-	return &sqlserverflex.UpdateInstanceRequestPayload{
+	return &sqlserverflexalpha.UpdateInstanceRequestPayload{
 		BackupSchedule: m.BackupSchedule.ValueStringPointer(),
 		FlavorId:       m.FlavorId.ValueStringPointer(),
 		Name:           m.Name.ValueStringPointer(),
-		Network: &sqlserverflex.UpdateInstanceRequestPayloadNetwork{
-			Acl: &netAcl,
-		},
-		Replicas:      &replVal,
-		RetentionDays: m.RetentionDays.ValueInt64Pointer(),
-		Storage:       &sqlserverflex.StorageUpdate{Size: m.Storage.Size.ValueInt64Pointer()},
-		Version:       sqlserverflex.UpdateInstanceRequestPayloadGetVersionAttributeType(m.Version.ValueStringPointer()),
+		Network:        sqlserverflexalpha.NewUpdateInstanceRequestPayloadNetwork(netAcl),
+		Replicas:       &replVal,
+		RetentionDays:  m.RetentionDays.ValueInt64Pointer(),
+		Storage:        &sqlserverflexalpha.StorageUpdate{Size: m.Storage.Size.ValueInt64Pointer()},
+		Version: sqlserverflexalpha.UpdateInstanceRequestPayloadGetVersionAttributeType(
+			m.Version.ValueStringPointer(),
+		),
 	}, nil
 }