stackit-dev-tools/terraform-provider-stackitprivatepreview
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: handle undefined creation time (#655)

Browse source
This commit is contained in:
Rüdiger Schmitz 2025-01-29 16:04:22 +01:00 • committed by GitHub
parent bcc8be0822
commit 3642260cc4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

20
stackit/internal/services/ske/kubeconfig/resource.go
View file

@ -394,8 +394,12 @@ func toCreatePayload(model *Model) (*ske.CreateKubeconfigPayload, error) {
// helper function to check if kubecondig has expired // helper function to check if kubecondig has expired
func checkHasExpired(model *Model, currentTime time.Time) (bool, error) { func checkHasExpired(model *Model, currentTime time.Time) (bool, error) {
if model.Refresh.ValueBool() && !model.ExpiresAt.IsNull() { expiresAt := model.ExpiresAt
expiresAt, err := time.Parse(time.RFC3339, model.ExpiresAt.ValueString()) if model.Refresh.ValueBool() && !expiresAt.IsNull() {
if expiresAt.IsUnknown() {
return true, nil
}
expiresAt, err := time.Parse(time.RFC3339, expiresAt.ValueString())
if err != nil { if err != nil {
return false, fmt.Errorf("converting expiresAt field to timestamp: %w", err) return false, fmt.Errorf("converting expiresAt field to timestamp: %w", err)
} }
@ -408,7 +412,11 @@ func checkHasExpired(model *Model, currentTime time.Time) (bool, error) {
// helper function to check if a credentials rotation was done // helper function to check if a credentials rotation was done
func checkCredentialsRotation(cluster *ske.Cluster, model *Model) (bool, error) { func checkCredentialsRotation(cluster *ske.Cluster, model *Model) (bool, error) {
creationTime, err := time.Parse(time.RFC3339, model.CreationTime.ValueString()) creationTimeValue := model.CreationTime
if creationTimeValue.IsNull() || creationTimeValue.IsUnknown() {
return false, nil
}
creationTime, err := time.Parse(time.RFC3339, creationTimeValue.ValueString())
if err != nil { if err != nil {
return false, fmt.Errorf("converting creationTime field to timestamp: %w", err) return false, fmt.Errorf("converting creationTime field to timestamp: %w", err)
} }
@ -422,7 +430,11 @@ func checkCredentialsRotation(cluster *ske.Cluster, model *Model) (bool, error)
// helper function to check if a cluster recreation was done // helper function to check if a cluster recreation was done
func checkClusterRecreation(cluster *ske.Cluster, model *Model) (bool, error) { func checkClusterRecreation(cluster *ske.Cluster, model *Model) (bool, error) {
creationTime, err := time.Parse(time.RFC3339, model.CreationTime.ValueString()) creationTimeValue := model.CreationTime
if creationTimeValue.IsNull() || creationTimeValue.IsUnknown() {
return false, nil
}
creationTime, err := time.Parse(time.RFC3339, creationTimeValue.ValueString())
if err != nil { if err != nil {
return false, fmt.Errorf("converting creationTime field to timestamp: %w", err) return false, fmt.Errorf("converting creationTime field to timestamp: %w", err)
} }