stackit-dev-tools/terraform-provider-stackitprivatepreview
2
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Make SQLServer edition computed (#389)

Browse source 
* Make edition computed

* generate docs
This commit is contained in:
Diogo Ferrão 2024-06-04 14:39:29 +01:00 • committed by GitHub
parent 04df2f2f89
commit 32b1fc1ef8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
stackit/internal/services/sqlserverflex/instance/resource.go
View file

@ -292,7 +292,6 @@ func (r *instanceResource) Schema(_ context.Context, _ resource.SchemaRequest, r
},
Attributes: map[string]schema.Attribute{
"edition": schema.StringAttribute{
Optional: true,
Computed: true,
PlanModifiers: []planmodifier.String{
stringplanmodifier.RequiresReplace(),
@ -695,9 +694,7 @@ func mapFields(ctx context.Context, resp *sqlserverflex.GetInstanceResponse, mod
edition := options.Edition
editionValue, ok := (*instance.Options)["edition"]
if ok {
// API returns edition in uppercase but validates if it is lowercase
// This is a workaround that should be removed when the API is fixed
edition = types.StringValue(strings.ToLower(editionValue))
edition = types.StringValue(editionValue)
}
optionsValues = map[string]attr.Value{

6
stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go
View file

@ -30,7 +30,6 @@ var instanceResource = map[string]string{
"storage_size": "40",
"version": "2022",
"replicas": "1",
"options_edition": "standard",
"options_retention_days": "64",
"flavor_id": "4.16-Single",
"backup_schedule": "00 6 * * *",
@ -55,7 +54,6 @@ func configResources(backupSchedule string) string {
}
version = "%s"
options = {
edition = "%s"
retention_days = %s
}
backup_schedule = "%s"
@ -70,7 +68,6 @@ func configResources(backupSchedule string) string {
instanceResource["storage_class"],
instanceResource["storage_size"],
instanceResource["version"],
instanceResource["options_edition"],
instanceResource["options_retention_days"],
backupSchedule,
)
@ -99,7 +96,6 @@ func TestAccSQLServerFlexResource(t *testing.T) {
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "storage.class", instanceResource["storage_class"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "storage.size", instanceResource["storage_size"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "version", instanceResource["version"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "options.edition", instanceResource["options_edition"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "options.retention_days", instanceResource["options_retention_days"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "backup_schedule", instanceResource["backup_schedule"]),
),
@ -135,7 +131,6 @@ func TestAccSQLServerFlexResource(t *testing.T) {
resource.TestCheckResourceAttr("data.stackit_sqlserverflex_instance.instance", "flavor.cpu", instanceResource["flavor_cpu"]),
resource.TestCheckResourceAttr("data.stackit_sqlserverflex_instance.instance", "flavor.ram", instanceResource["flavor_ram"]),
resource.TestCheckResourceAttr("data.stackit_sqlserverflex_instance.instance", "replicas", instanceResource["replicas"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "options.edition", instanceResource["options_edition"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "options.retention_days", instanceResource["options_retention_days"]),
resource.TestCheckResourceAttr("data.stackit_sqlserverflex_instance.instance", "backup_schedule", instanceResource["backup_schedule"]),
),
@ -186,7 +181,6 @@ func TestAccSQLServerFlexResource(t *testing.T) {
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "storage.class", instanceResource["storage_class"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "storage.size", instanceResource["storage_size"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "version", instanceResource["version"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "options.edition", instanceResource["options_edition"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "options.retention_days", instanceResource["options_retention_days"]),
resource.TestCheckResourceAttr("stackit_sqlserverflex_instance.instance", "backup_schedule", instanceResource["backup_schedule_updated"]),
),