fix: builder and sdk changes (#81)

## Description

<!-- **Please link some issue here describing what you are trying to achieve.**

In case there is no issue present for your PR, please consider creating one.
At least please give us some description what you are trying to achieve and why your change is needed. -->

relates to #1234

## Checklist

- [ ] Issue was linked above
- [ ] Code format was applied: `make fmt`
- [ ] Examples were added / adjusted (see `examples/` directory)
- [x] Docs are up-to-date: `make generate-docs` (will be checked by CI)
- [ ] Unit tests got implemented or updated
- [ ] Acceptance tests got implemented or updated (see e.g. [here](f5f99d1709/stackit/internal/services/dns/dns_acc_test.go))
- [x] Unit tests are passing: `make test` (will be checked by CI)
- [x] No linter issues: `make lint` (will be checked by CI)

Co-authored-by: Marcel S. Henselin <marcel.henselin@stackit.cloud>
Co-authored-by: marcel.henselin <marcel.henselin@stackit.cloud>
Reviewed-on: #81

stackit/internal/services/postgresflexalpha/database/functions_test.go

@@ -5,127 +5,99 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/stackitcloud/stackit-sdk-go/core/utils"
-
-	postgresflex "tf-provider.git.onstackit.cloud/stackit-dev-tools/terraform-provider-stackitprivatepreview/pkg_gen/postgresflexalpha"
+	"github.com/stackitcloud/stackit-sdk-go/services/postgresflex/v3alpha1api"
 )
 
-type mockRequest struct {
-	executeFunc func() (*postgresflex.ListDatabasesResponse, error)
-}
-
-func (m *mockRequest) Page(_ int32) postgresflex.ApiListDatabasesRequestRequest { return m }
-func (m *mockRequest) Size(_ int32) postgresflex.ApiListDatabasesRequestRequest { return m }
-func (m *mockRequest) Sort(_ postgresflex.DatabaseSort) postgresflex.ApiListDatabasesRequestRequest {
-	return m
-}
-func (m *mockRequest) Execute() (*postgresflex.ListDatabasesResponse, error) {
-	return m.executeFunc()
-}
-
-type mockDBClient struct {
-	executeRequest func() postgresflex.ApiListDatabasesRequestRequest
-}
-
-var _ databaseClientReader = (*mockDBClient)(nil)
-
-func (m *mockDBClient) ListDatabasesRequest(
-	_ context.Context,
-	_, _, _ string,
-) postgresflex.ApiListDatabasesRequestRequest {
-	return m.executeRequest()
-}
-
 func TestGetDatabase(t *testing.T) {
-	mockResp := func(page int64) (*postgresflex.ListDatabasesResponse, error) {
+	mockResp := func(page int32) (*v3alpha1api.ListDatabasesResponse, error) {
 		if page == 1 {
-			return &postgresflex.ListDatabasesResponse{
-				Databases: &[]postgresflex.ListDatabase{
-					{Id: utils.Ptr(int64(1)), Name: utils.Ptr("first")},
-					{Id: utils.Ptr(int64(2)), Name: utils.Ptr("second")},
+			return &v3alpha1api.ListDatabasesResponse{
+				Databases: []v3alpha1api.ListDatabase{
+					{Id: int32(1), Name: "first"},
+					{Id: int32(2), Name: "second"},
 				},
-				Pagination: &postgresflex.Pagination{
-					Page:       utils.Ptr(int64(1)),
-					TotalPages: utils.Ptr(int64(2)),
-					Size:       utils.Ptr(int64(3)),
+				Pagination: v3alpha1api.Pagination{
+					Page:       int32(1),
+					TotalPages: int32(2),
+					Size:       int32(3),
 				},
 			}, nil
 		}
 
 		if page == 2 {
-			return &postgresflex.ListDatabasesResponse{
-				Databases: &[]postgresflex.ListDatabase{{Id: utils.Ptr(int64(3)), Name: utils.Ptr("three")}},
-				Pagination: &postgresflex.Pagination{
-					Page:       utils.Ptr(int64(2)),
-					TotalPages: utils.Ptr(int64(2)),
-					Size:       utils.Ptr(int64(3)),
+			return &v3alpha1api.ListDatabasesResponse{
+				Databases: []v3alpha1api.ListDatabase{{Id: int32(3), Name: "three"}},
+				Pagination: v3alpha1api.Pagination{
+					Page:       int32(2),
+					TotalPages: int32(2),
+					Size:       int32(3),
 				},
 			}, nil
 		}
 
-		return &postgresflex.ListDatabasesResponse{
-			Databases: &[]postgresflex.ListDatabase{},
-			Pagination: &postgresflex.Pagination{
-				Page:       utils.Ptr(int64(3)),
-				TotalPages: utils.Ptr(int64(2)),
-				Size:       utils.Ptr(int64(3)),
+		return &v3alpha1api.ListDatabasesResponse{
+			Databases: []v3alpha1api.ListDatabase{},
+			Pagination: v3alpha1api.Pagination{
+				Page:       int32(3),
+				TotalPages: int32(2),
+				Size:       int32(3),
 			},
 		}, nil
 	}
 
 	tests := []struct {
 		description string
-		projectId   string
+		projectID   string
 		region      string
-		instanceId  string
+		instanceID  string
 		wantErr     bool
 		wantDbName  string
-		wantDbId    int64
+		wantDbID    int32
 	}{
 		{
 			description: "Success - Found by name on first page",
-			projectId:   "pid", region: "reg", instanceId: "inst",
+			projectID:   "pid", region: "reg", instanceID: "inst",
 			wantErr:    false,
 			wantDbName: "second",
 		},
 		{
 			description: "Success - Found by id on first page",
-			projectId:   "pid", region: "reg", instanceId: "inst",
+			projectID:   "pid", region: "reg", instanceID: "inst",
 			wantErr:  false,
-			wantDbId: 2,
+			wantDbID: 2,
 		},
 		{
 			description: "Success - Found by name on second page",
-			projectId:   "pid", region: "reg", instanceId: "inst",
+			projectID:   "pid", region: "reg", instanceID: "inst",
 			wantErr:    false,
 			wantDbName: "three",
 		},
 		{
 			description: "Success - Found by id on second page",
-			projectId:   "pid", region: "reg", instanceId: "inst",
+			projectID:   "pid", region: "reg", instanceID: "inst",
 			wantErr:  false,
-			wantDbId: 1,
+			wantDbID: 1,
 		},
 		{
 			description: "Error - API failure",
-			projectId:   "pid", region: "reg", instanceId: "inst",
+			projectID:   "pid", region: "reg", instanceID: "inst",
 			wantErr: true,
 		},
 		{
 			description: "Error - Missing parameters",
-			projectId:   "", region: "reg", instanceId: "inst",
+			projectID:   "", region: "reg", instanceID: "inst",
 			wantErr: true,
 		},
 		{
 			description: "Error - Search by name not found after all pages",
-			projectId:   "pid", region: "reg", instanceId: "inst",
+			projectID:   "pid", region: "reg", instanceID: "inst",
 			wantDbName: "non-existent",
 			wantErr:    true,
 		},
 		{
 			description: "Error - Search by id not found after all pages",
-			projectId:   "pid", region: "reg", instanceId: "inst",
-			wantDbId: 999999,
+			projectID:   "pid", region: "reg", instanceID: "inst",
+			wantDbID: 999999,
 			wantErr:  true,
 		},
 	}
@@ -133,47 +105,46 @@ func TestGetDatabase(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(
 			tt.description, func(t *testing.T) {
-				var currentPage int64
-				client := &mockDBClient{
-					executeRequest: func() postgresflex.ApiListDatabasesRequestRequest {
-						return &mockRequest{
-							executeFunc: func() (*postgresflex.ListDatabasesResponse, error) {
-								currentPage++
-								return mockResp(currentPage)
-							},
-						}
-					},
+				var currentPage int32
+
+				mockCall := func(_ v3alpha1api.ApiListDatabasesRequestRequest) (*v3alpha1api.ListDatabasesResponse, error) {
+					currentPage++
+					return mockResp(currentPage)
 				}
 
-				var actual *postgresflex.ListDatabase
+				client := &v3alpha1api.DefaultAPIServiceMock{
+					ListDatabasesRequestExecuteMock: &mockCall,
+				}
+
+				var actual *v3alpha1api.ListDatabase
 				var errDB error
 
 				if tt.wantDbName != "" {
 					actual, errDB = getDatabaseByName(
 						t.Context(),
 						client,
-						tt.projectId,
+						tt.projectID,
 						tt.region,
-						tt.instanceId,
+						tt.instanceID,
 						tt.wantDbName,
 					)
-				} else if tt.wantDbId != 0 {
+				} else if tt.wantDbID != 0 {
 					actual, errDB = getDatabaseById(
 						t.Context(),
 						client,
-						tt.projectId,
+						tt.projectID,
 						tt.region,
-						tt.instanceId,
-						tt.wantDbId,
+						tt.instanceID,
+						int64(tt.wantDbID),
 					)
 				} else {
 					actual, errDB = getDatabase(
 						context.Background(),
 						client,
-						tt.projectId,
+						tt.projectID,
 						tt.region,
-						tt.instanceId,
-						func(_ postgresflex.ListDatabase) bool { return false },
+						tt.instanceID,
+						func(_ v3alpha1api.ListDatabase) bool { return false },
 					)
 				}
 
@@ -182,14 +153,14 @@ func TestGetDatabase(t *testing.T) {
 					return
 				}
 				if !tt.wantErr && tt.wantDbName != "" && actual != nil {
-					if *actual.Name != tt.wantDbName {
-						t.Errorf("getDatabaseByNameOrID() got name = %v, want %v", *actual.Name, tt.wantDbName)
+					if actual.Name != tt.wantDbName {
+						t.Errorf("getDatabaseByNameOrID() got name = %v, want %v", actual.Name, tt.wantDbName)
 					}
 				}
 
-				if !tt.wantErr && tt.wantDbId != 0 && actual != nil {
-					if *actual.Id != tt.wantDbId {
-						t.Errorf("getDatabaseByNameOrID() got id = %v, want %v", *actual.Id, tt.wantDbId)
+				if !tt.wantErr && tt.wantDbID != 0 && actual != nil {
+					if actual.Id != tt.wantDbID {
+						t.Errorf("getDatabaseByNameOrID() got id = %v, want %v", actual.Id, tt.wantDbID)
 					}
 				}
 			},
@@ -200,23 +171,18 @@ func TestGetDatabase(t *testing.T) {
 func TestCleanString(t *testing.T) {
 	testcases := []struct {
 		name     string
-		given    *string
-		expected *string
+		given    string
+		expected string
 	}{
 		{
 			name:     "should remove quotes",
-			given:    utils.Ptr("\"quoted\""),
-			expected: utils.Ptr("quoted"),
-		},
-		{
-			name:     "should handle nil",
-			given:    nil,
-			expected: nil,
+			given:    "\"quoted\"",
+			expected: "quoted",
 		},
 		{
 			name:     "should not change unquoted string",
-			given:    utils.Ptr("unquoted"),
-			expected: utils.Ptr("unquoted"),
+			given:    "unquoted",
+			expected: "unquoted",
 		},
 	}