Implement object storage credential (#79)
* Implement credential resource * Implement test * Fix test * Implement data source * Implement credential acc test * Add objectstorage credential * Add test for enableProject * Add readCredentials test * Removed unnecessary test case * Generate docs * Fix lint * Fix field name * Readd credentials group checks * Fix comment * Fix comment * Remove auth --------- Co-authored-by: Henrique Santos <henrique.santos@freiheit.com>
This commit is contained in:
Henrique Santos
GitHub
parent
f9b245ffb4
commit
0fb7d0d793
9 changed files with 1096 additions and 0 deletions
|
|
@ -0,0 +1,374 @@
|
|||
package objectstorage
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/google/go-cmp/cmp"
|
||||
"github.com/hashicorp/terraform-plugin-framework-timetypes/timetypes"
|
||||
"github.com/hashicorp/terraform-plugin-framework/types"
|
||||
"github.com/stackitcloud/stackit-sdk-go/core/config"
|
||||
"github.com/stackitcloud/stackit-sdk-go/core/utils"
|
||||
"github.com/stackitcloud/stackit-sdk-go/services/objectstorage"
|
||||
)
|
||||
|
||||
type objectStorageClientMocked struct {
|
||||
returnError bool
|
||||
}
|
||||
|
||||
func (c *objectStorageClientMocked) CreateProjectExecute(_ context.Context, projectId string) (*objectstorage.GetProjectResponse, error) {
|
||||
if c.returnError {
|
||||
return nil, fmt.Errorf("create project failed")
|
||||
}
|
||||
|
||||
return &objectstorage.GetProjectResponse{
|
||||
Project: utils.Ptr(projectId),
|
||||
}, nil
|
||||
}
|
||||
|
||||
func TestMapFields(t *testing.T) {
|
||||
timeValue := time.Now()
|
||||
|
||||
tests := []struct {
|
||||
description string
|
||||
input *objectstorage.CreateAccessKeyResponse
|
||||
expected Model
|
||||
isValid bool
|
||||
}{
|
||||
{
|
||||
"default_values",
|
||||
&objectstorage.CreateAccessKeyResponse{},
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringNull(),
|
||||
AccessKey: types.StringNull(),
|
||||
SecretAccessKey: types.StringNull(),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339Null(),
|
||||
},
|
||||
true,
|
||||
},
|
||||
{
|
||||
"simple_values",
|
||||
&objectstorage.CreateAccessKeyResponse{
|
||||
AccessKey: utils.Ptr("key"),
|
||||
DisplayName: utils.Ptr("name"),
|
||||
Expires: utils.Ptr(timeValue.Format(time.RFC3339)),
|
||||
SecretAccessKey: utils.Ptr("secret-key"),
|
||||
},
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringValue("name"),
|
||||
AccessKey: types.StringValue("key"),
|
||||
SecretAccessKey: types.StringValue("secret-key"),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339TimeValue(timeValue),
|
||||
},
|
||||
true,
|
||||
},
|
||||
{
|
||||
"empty_strings",
|
||||
&objectstorage.CreateAccessKeyResponse{
|
||||
AccessKey: utils.Ptr(""),
|
||||
DisplayName: utils.Ptr(""),
|
||||
SecretAccessKey: utils.Ptr(""),
|
||||
},
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringValue(""),
|
||||
AccessKey: types.StringValue(""),
|
||||
SecretAccessKey: types.StringValue(""),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339Null(),
|
||||
},
|
||||
true,
|
||||
},
|
||||
{
|
||||
"nil_response",
|
||||
nil,
|
||||
Model{},
|
||||
false,
|
||||
},
|
||||
{
|
||||
"bad_time",
|
||||
&objectstorage.CreateAccessKeyResponse{
|
||||
Expires: utils.Ptr("foo-bar"),
|
||||
},
|
||||
Model{},
|
||||
false,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.description, func(t *testing.T) {
|
||||
model := &Model{
|
||||
ProjectId: tt.expected.ProjectId,
|
||||
CredentialsGroupId: tt.expected.CredentialsGroupId,
|
||||
CredentialId: tt.expected.CredentialId,
|
||||
}
|
||||
err := mapFields(tt.input, model)
|
||||
if !tt.isValid && err == nil {
|
||||
t.Fatalf("Should have failed")
|
||||
}
|
||||
if tt.isValid && err != nil {
|
||||
t.Fatalf("Should not have failed: %v", err)
|
||||
}
|
||||
if tt.isValid {
|
||||
diff := cmp.Diff(model, &tt.expected)
|
||||
if diff != "" {
|
||||
t.Fatalf("Data does not match: %s", diff)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestEnableProject(t *testing.T) {
|
||||
tests := []struct {
|
||||
description string
|
||||
expected Model
|
||||
enableFails bool
|
||||
isValid bool
|
||||
}{
|
||||
{
|
||||
"default_values",
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringNull(),
|
||||
AccessKey: types.StringNull(),
|
||||
SecretAccessKey: types.StringNull(),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339Null(),
|
||||
},
|
||||
false,
|
||||
true,
|
||||
},
|
||||
{
|
||||
"error_response",
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringNull(),
|
||||
AccessKey: types.StringNull(),
|
||||
SecretAccessKey: types.StringNull(),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339Null(),
|
||||
},
|
||||
true,
|
||||
false,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.description, func(t *testing.T) {
|
||||
client := &objectStorageClientMocked{
|
||||
returnError: tt.enableFails,
|
||||
}
|
||||
model := &Model{
|
||||
ProjectId: tt.expected.ProjectId,
|
||||
CredentialsGroupId: tt.expected.CredentialsGroupId,
|
||||
CredentialId: tt.expected.CredentialId,
|
||||
}
|
||||
err := enableProject(context.Background(), model, client)
|
||||
if !tt.isValid && err == nil {
|
||||
t.Fatalf("Should have failed")
|
||||
}
|
||||
if tt.isValid && err != nil {
|
||||
t.Fatalf("Should not have failed: %v", err)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestReadCredentials(t *testing.T) {
|
||||
timeValue := time.Now()
|
||||
|
||||
tests := []struct {
|
||||
description string
|
||||
mockedResp *objectstorage.GetAccessKeysResponse
|
||||
expected Model
|
||||
getCredentialsFails bool
|
||||
isValid bool
|
||||
}{
|
||||
{
|
||||
"default_values",
|
||||
&objectstorage.GetAccessKeysResponse{
|
||||
AccessKeys: &[]objectstorage.AccessKey{
|
||||
{
|
||||
KeyId: utils.Ptr("foo-cid"),
|
||||
},
|
||||
{
|
||||
KeyId: utils.Ptr("bar-cid"),
|
||||
},
|
||||
{
|
||||
KeyId: utils.Ptr("cid"),
|
||||
},
|
||||
},
|
||||
},
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringNull(),
|
||||
AccessKey: types.StringNull(),
|
||||
SecretAccessKey: types.StringNull(),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339Null(),
|
||||
},
|
||||
false,
|
||||
true,
|
||||
},
|
||||
{
|
||||
"simple_values",
|
||||
&objectstorage.GetAccessKeysResponse{
|
||||
AccessKeys: &[]objectstorage.AccessKey{
|
||||
{
|
||||
KeyId: utils.Ptr("foo-cid"),
|
||||
DisplayName: utils.Ptr("foo-name"),
|
||||
Expires: utils.Ptr(timeValue.Add(time.Hour).Format(time.RFC3339)),
|
||||
},
|
||||
{
|
||||
KeyId: utils.Ptr("bar-cid"),
|
||||
DisplayName: utils.Ptr("bar-name"),
|
||||
Expires: utils.Ptr(timeValue.Add(time.Minute).Format(time.RFC3339)),
|
||||
},
|
||||
{
|
||||
KeyId: utils.Ptr("cid"),
|
||||
DisplayName: utils.Ptr("name"),
|
||||
Expires: utils.Ptr(timeValue.Format(time.RFC3339)),
|
||||
},
|
||||
},
|
||||
},
|
||||
Model{
|
||||
Id: types.StringValue("pid,cgid,cid"),
|
||||
ProjectId: types.StringValue("pid"),
|
||||
CredentialsGroupId: types.StringValue("cgid"),
|
||||
CredentialId: types.StringValue("cid"),
|
||||
Name: types.StringValue("name"),
|
||||
AccessKey: types.StringNull(),
|
||||
SecretAccessKey: types.StringNull(),
|
||||
ExpirationTimestamp: timetypes.NewRFC3339TimeValue(timeValue),
|
||||
},
|
||||
false,
|
||||
true,
|
||||
},
|
||||
{
|
||||
"empty_credentials",
|
||||
&objectstorage.GetAccessKeysResponse{
|
||||
AccessKeys: &[]objectstorage.AccessKey{},
|
||||
},
|
||||
Model{},
|
||||
false,
|
||||
false,
|
||||
},
|
||||
{
|
||||
"nil_response",
|
||||
nil,
|
||||
Model{},
|
||||
false,
|
||||
false,
|
||||
},
|
||||
{
|
||||
"non_matching_credential",
|
||||
&objectstorage.GetAccessKeysResponse{
|
||||
AccessKeys: &[]objectstorage.AccessKey{
|
||||
{
|
||||
KeyId: utils.Ptr("foo-cid"),
|
||||
DisplayName: utils.Ptr("foo-name"),
|
||||
Expires: utils.Ptr(timeValue.Add(time.Hour).Format(time.RFC3339)),
|
||||
},
|
||||
{
|
||||
KeyId: utils.Ptr("bar-cid"),
|
||||
DisplayName: utils.Ptr("bar-name"),
|
||||
Expires: utils.Ptr(timeValue.Add(time.Minute).Format(time.RFC3339)),
|
||||
},
|
||||
},
|
||||
},
|
||||
Model{},
|
||||
false,
|
||||
false,
|
||||
},
|
||||
{
|
||||
"error_response",
|
||||
&objectstorage.GetAccessKeysResponse{
|
||||
AccessKeys: &[]objectstorage.AccessKey{
|
||||
{
|
||||
KeyId: utils.Ptr("cid"),
|
||||
DisplayName: utils.Ptr("name"),
|
||||
Expires: utils.Ptr(timeValue.Format(time.RFC3339)),
|
||||
},
|
||||
},
|
||||
},
|
||||
Model{},
|
||||
true,
|
||||
false,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.description, func(t *testing.T) {
|
||||
mockedRespBytes, err := json.Marshal(tt.mockedResp)
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to marshal mocked response: %v", err)
|
||||
}
|
||||
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.Header().Set("Content-Type", "application/json")
|
||||
if tt.getCredentialsFails {
|
||||
w.WriteHeader(http.StatusBadGateway)
|
||||
w.Header().Set("Content-Type", "application/json")
|
||||
_, err := w.Write([]byte("{\"message\": \"Something bad happened\""))
|
||||
if err != nil {
|
||||
t.Errorf("Failed to write bad response: %v", err)
|
||||
}
|
||||
return
|
||||
}
|
||||
|
||||
_, err := w.Write(mockedRespBytes)
|
||||
if err != nil {
|
||||
t.Errorf("Failed to write response: %v", err)
|
||||
}
|
||||
})
|
||||
mockedServer := httptest.NewServer(handler)
|
||||
defer mockedServer.Close()
|
||||
client, err := objectstorage.NewAPIClient(
|
||||
config.WithoutAuthentication(),
|
||||
config.WithEndpoint(mockedServer.URL),
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to initialize client: %v", err)
|
||||
}
|
||||
|
||||
model := &Model{
|
||||
ProjectId: tt.expected.ProjectId,
|
||||
CredentialsGroupId: tt.expected.CredentialsGroupId,
|
||||
CredentialId: tt.expected.CredentialId,
|
||||
}
|
||||
err = readCredentials(context.Background(), model, client)
|
||||
if !tt.isValid && err == nil {
|
||||
t.Fatalf("Should have failed")
|
||||
}
|
||||
if tt.isValid && err != nil {
|
||||
t.Fatalf("Should not have failed: %v", err)
|
||||
}
|
||||
if tt.isValid {
|
||||
diff := cmp.Diff(model, &tt.expected)
|
||||
if diff != "" {
|
||||
t.Fatalf("Data does not match: %s", diff)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue