From 04ce56b3d6c8366ae921ba9b37ba0c6bda10e953 Mon Sep 17 00:00:00 2001 From: Christian Hamm Date: Thu, 10 Oct 2024 12:15:01 +0200 Subject: [PATCH] Increase the target count per pool from 250 to 1000 to be ready for large SKE clusters (#550) Co-authored-by: Christian Hamm --- docs/data-sources/loadbalancer.md | 2 +- docs/resources/loadbalancer.md | 2 +- .../services/loadbalancer/loadbalancer/datasource.go | 4 ++-- .../internal/services/loadbalancer/loadbalancer/resource.go | 5 ++--- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/data-sources/loadbalancer.md b/docs/data-sources/loadbalancer.md index e91af21f..9d81a1c8 100644 --- a/docs/data-sources/loadbalancer.md +++ b/docs/data-sources/loadbalancer.md @@ -90,7 +90,7 @@ Read-Only: - `active_health_check` (Attributes) (see [below for nested schema](#nestedatt--target_pools--active_health_check)) - `name` (String) Target pool name. - `target_port` (Number) Identical port number where each target listens for traffic. -- `targets` (Attributes List) List of all targets which will be used in the pool. Limited to 250. (see [below for nested schema](#nestedatt--target_pools--targets)) +- `targets` (Attributes List) List of all targets which will be used in the pool. Limited to 1000. (see [below for nested schema](#nestedatt--target_pools--targets)) ### Nested Schema for `target_pools.session_persistence` diff --git a/docs/resources/loadbalancer.md b/docs/resources/loadbalancer.md index e5e4bbfe..48034f97 100644 --- a/docs/resources/loadbalancer.md +++ b/docs/resources/loadbalancer.md @@ -233,7 +233,7 @@ Required: - `name` (String) Target pool name. - `target_port` (Number) Identical port number where each target listens for traffic. -- `targets` (Attributes List) List of all targets which will be used in the pool. Limited to 250. (see [below for nested schema](#nestedatt--target_pools--targets)) +- `targets` (Attributes List) List of all targets which will be used in the pool. Limited to 1000. (see [below for nested schema](#nestedatt--target_pools--targets)) Optional: diff --git a/stackit/internal/services/loadbalancer/loadbalancer/datasource.go b/stackit/internal/services/loadbalancer/loadbalancer/datasource.go index 114561fc..5bc4afd8 100644 --- a/stackit/internal/services/loadbalancer/loadbalancer/datasource.go +++ b/stackit/internal/services/loadbalancer/loadbalancer/datasource.go @@ -108,7 +108,7 @@ func (r *loadBalancerDataSource) Schema(_ context.Context, _ datasource.SchemaRe "unhealthy_threshold": "Unhealthy threshold of the health checking.", "target_pools.name": "Target pool name.", "target_port": "Identical port number where each target listens for traffic.", - "targets": "List of all targets which will be used in the pool. Limited to 250.", + "targets": "List of all targets which will be used in the pool. Limited to 1000.", "targets.display_name": "Target display name", "ip": "Target IP", } @@ -284,7 +284,7 @@ func (r *loadBalancerDataSource) Schema(_ context.Context, _ datasource.SchemaRe Description: descriptions["targets"], Computed: true, Validators: []validator.List{ - listvalidator.SizeBetween(1, 250), + listvalidator.SizeBetween(1, 1000), }, NestedObject: schema.NestedAttributeObject{ Attributes: map[string]schema.Attribute{ diff --git a/stackit/internal/services/loadbalancer/loadbalancer/resource.go b/stackit/internal/services/loadbalancer/loadbalancer/resource.go index 35bb7c85..cac41e68 100644 --- a/stackit/internal/services/loadbalancer/loadbalancer/resource.go +++ b/stackit/internal/services/loadbalancer/loadbalancer/resource.go @@ -252,7 +252,7 @@ func (r *loadBalancerResource) Schema(_ context.Context, _ resource.SchemaReques "unhealthy_threshold": "Unhealthy threshold of the health checking.", "target_pools.name": "Target pool name.", "target_port": "Identical port number where each target listens for traffic.", - "targets": "List of all targets which will be used in the pool. Limited to 250.", + "targets": "List of all targets which will be used in the pool. Limited to 1000.", "targets.display_name": "Target display name", "ip": "Target IP", } @@ -267,7 +267,6 @@ func (r *loadBalancerResource) Schema(_ context.Context, _ resource.SchemaReques To automate the creation of load balancers, OpenStack can be used to setup the supporting infrastructure. To set up the OpenStack provider, you can create a token through the STACKIT Portal, in your project's Infrastructure API page. There, the OpenStack user domain name, username, and password are generated and can be obtained. The provider can then be configured as follows:` + "\n" + - "```terraform" + ` terraform { required_providers { @@ -536,7 +535,7 @@ The example below uses OpenStack to create the network, router, a public IP addr Description: descriptions["targets"], Required: true, Validators: []validator.List{ - listvalidator.SizeBetween(1, 250), + listvalidator.SizeBetween(1, 1000), }, NestedObject: schema.NestedAttributeObject{ Attributes: map[string]schema.Attribute{